From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E77963858C53 for ; Wed, 25 Jan 2023 16:49:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E77963858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674665356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FUapPzABBjV1AnA7OR0WMkO9/5uNe3w54eHFo7PdC5Q=; b=TIiY9Nl0fTGLcq/gXhzDWr3FleeeUwfyJ8IfI0lRzSCf48COS+UwxmE6AONYZ+XnnpK6eM rKqd1RHsEAbx7/l1218sgaukDQz7uQIlmk2ht0Wt/3U4XSgc1wSll8U1NbDUmY+f3NUThO ToWTWj84NPLcnThUZLywEkxV11S6VWQ= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-38-eBh3RHmIP4qYpgKrP04pLg-1; Wed, 25 Jan 2023 11:49:15 -0500 X-MC-Unique: eBh3RHmIP4qYpgKrP04pLg-1 Received: by mail-vk1-f197.google.com with SMTP id s203-20020a1f2cd4000000b003d5b4915319so7532475vks.18 for ; Wed, 25 Jan 2023 08:49:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FUapPzABBjV1AnA7OR0WMkO9/5uNe3w54eHFo7PdC5Q=; b=AGlXmt0M4byZdY9vp8i7YCidjf0okBo0gW14SpgMALjhMTv6MFRAmeB2PQ1SJ9I+Ee rqG8c34YdTXlE8fAnYx8Z5HFPVrKIVLQuG/+EZqawZ5wXtyDykYbzEoBgJT5/3oppyb0 FdSjyBH9R6f8xCQXW8807gdgB1zNCCeaIkAonlPz0vv7bD5/7f9uNMo0CZDmMyzisZ6D jZB2z9E8Bd1PXuF+HE2h3ed+8S65ckZz1spDRmewEf6Xdp2+6j7oUea57DlEw6q+kUah bPcZ7RTbTb/Auf4HxKjtSfFrZaFoKbr7NiTiLwsfykNPXkjDXPiG/V/pBpy9jIoLvo6m VyzQ== X-Gm-Message-State: AFqh2kqXSlZd8a+PTl1zFrgSutQTLQn2fP8eh95UuTRDvKu9gIqhoFbS K9Lv3w90Jtyh6JqBaLnCYu4d737VZ+VyyXoF4VDzuOLY3H/SWHtfpzDNX6+6WLExARCiCO13kb/ QEmaoQYNwwH0rAKuLae1qRg== X-Received: by 2002:a05:6102:127c:b0:3d0:af13:3ae with SMTP id q28-20020a056102127c00b003d0af1303aemr18309451vsg.17.1674665354314; Wed, 25 Jan 2023 08:49:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuy4vQzxDTsvOj/QXGeydubRyNIa7GNCnglmqRZdkpFAZe7IxyGA0cIZOqwXD0ynNReyO6CJQ== X-Received: by 2002:a05:6102:127c:b0:3d0:af13:3ae with SMTP id q28-20020a056102127c00b003d0af1303aemr18309435vsg.17.1674665354059; Wed, 25 Jan 2023 08:49:14 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id h15-20020a05620a13ef00b006cec8001bf4sm3829461qkl.26.2023.01.25.08.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 08:49:13 -0800 (PST) From: Andrew Burgess To: "Aktemur, Tankut Baris" , Eli Zaretskii , "gdb-patches@sourceware.org" Subject: RE: [PATCHv2 03/13] gdb: include breakpoint number in testing condition error message In-Reply-To: References: <478a1e660361f1290c2dd8e9ad999d59d0ad3dcb.1674058359.git.aburgess@redhat.com> <838rhypxlg.fsf@gnu.org> Date: Wed, 25 Jan 2023 16:49:11 +0000 Message-ID: <87zga6v9tk.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Aktemur, Tankut Baris" writes: > On Thursday, January 19, 2023 12:34 PM, Eli Zaretskii wrote: >> > From: "Aktemur, Tankut Baris" >> > Date: Thu, 19 Jan 2023 10:54:16 +0000 >> > >> > On Wednesday, January 18, 2023 5:18 PM, Andrew Burgess wrote: >> > ... >> > > So, in this commit, in preparation for the later commits, I propose to >> > > change the 'Error in testing breakpoint condition:' line to this: >> > > >> > > Error in testing condition for breakpoint NUMBER: >> > >> > Here, because we're now referring to a particular breakpoint, >> > I believe the spelling should be "condition for Breakpoint NUMBER:", >> > with uppercase 'B'. Maybe Eli can comment on this, too. >> >> No, capitalized "Breakpoint" would read wrong English-wise in that >> case. > > For me to better understand the rule, wouldn't it be the same as > "see in figure 5" vs. "see in Figure 5", or "given in section 2.1" > vs. "given in Section 2.1"? Given the number of corrections I get for my doc edits, this should be taken with a pinch of salt, but ... ... in the examples you give "Figure 5" and "Section 2.1" would be the actual name of a thing, e.g. there will be a figure somewhere with the title "Figure 5" and a section somewhere titled "Section 2.1", thus the capitalisation is correct because you're referencing a named thing. In the breakpoint case, what we're referencing isn't _named_ Breakpoint 5, it just is the 5th breakpoint. At least, that's what I'd do unless told different :) Thanks, Andrew