From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 7D3123858D1E for ; Tue, 24 Jan 2023 23:15:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D3123858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id EE16D100476EF for ; Tue, 24 Jan 2023 23:15:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KSVrpHGyVgsICKSVrpJPzK; Tue, 24 Jan 2023 23:15:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=H7Ief8Ui c=1 sm=1 tr=0 ts=63d06697 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=n9Nvxce8AAAA:8 a=jDL3sfu55LqdQDu3w-cA:9 a=VxAk22fqlfwA:10:nop_delegated_string_gtld_1 a=V4tbcg9hxeXQX3VEsxKP:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wzerl76eN4AShfPHrM0Ng3WrSp2aGE9NOFc4a0gYqd4=; b=fNKYCS2KujrXXbxfipM7YBoR6W gf42VHT3JdBal/TKWztMA0GcNF4d7SWi6jB/64OlnDJE5R3Y8r5FG2NwBmqCwvL8O2hjpm/+U8LsE JLSAOMhWQZ23svr72gN+EwsHC; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:35908 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKSVr-003p2G-ET; Tue, 24 Jan 2023 16:15:35 -0700 From: Tom Tromey To: Mark Wielaard Cc: gdb-patches@sourceware.org, Simon Marchi , Sam James , Tom Tromey , John Baldwin Subject: Re: [PATCHv4] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc References: <20230124223130.982276-1-mark@klomp.org> X-Attribution: Tom Date: Tue, 24 Jan 2023 16:15:32 -0700 In-Reply-To: <20230124223130.982276-1-mark@klomp.org> (Mark Wielaard's message of "Tue, 24 Jan 2023 23:31:30 +0100") Message-ID: <87zga7ikx7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKSVr-003p2G-ET X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:35908 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Mark" == Mark Wielaard writes: Mark> - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); ... Mark> + std::copy (buf->data (), buf->data () + sizeof (structsize), Mark> + desc.data () + sizeof (structsize)); I think this should probably copy buf->size() bytes. So maybe buf->begin() and buf->end() ? Tom