From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.esperi.org.uk (icebox.esperi.org.uk [81.187.191.129]) by sourceware.org (Postfix) with ESMTPS id 46F093858D33 for ; Mon, 16 Jan 2023 13:51:12 +0000 (GMT) Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=oracle.com Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.16.1/8.16.1) with ESMTPS id 30GDp7bH018461 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 16 Jan 2023 13:51:08 GMT From: Nick Alcock To: Enze Li via Binutils Cc: Enze Li , gdb-patches@sourceware.org, enze.li@gmx.com, eliz@gnu.org, schwab@linux-m68k.org Subject: Re: [PATCH v2] libctf: update regexp to allow makeinfo to build document References: Emacs: because editing your files should be a traumatic experience. Date: Mon, 16 Jan 2023 13:51:07 +0000 In-Reply-To: (Enze Li via Binutils's message of "Sat, 14 Jan 2023 12:23:26 +0800") Message-ID: <87zgaioaes.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: loom 1480; Body=6 Fuz1=6 Fuz2=6 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,KHOP_HELO_FCRDNS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14 Jan 2023, Enze Li via Binutils verbalised: > While trying to build gdb on latest openSUSE Tumbleweed, I noticed the > following warning, > > checking for makeinfo... makeinfo --split-size=5000000 > configure: WARNING: > *** Makeinfo is too old. Info documentation will not be built. > > then I checked the version of makeinfo, it said, > ====== > $ makeinfo --version > texi2any (GNU texinfo) 7.0.1 > > Copyright (C) 2022 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > ====== > > After digging a little bit, it became quite obvious that a dot is > missing in regexp that makes it impossible to match versions higher than > 7.0, and here's the solution: > > - | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9][0-9])' >/dev/null 2>&1; then > + | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9]\.[0-9])' >/dev/null 2>&1; then > > However, Eli pointed out that the solution above has another problem: it > will stop working when Texinfo 10.1 will be released. Meanwhile, he > suggested to solve this problem permanently. That is, we don't care > about the minor version for Texinfo > 6.9, we only care about the major > version. > > In this way, problem solved permanently, thanks to Eli. Looks good to me: approved. (I can commit it if you like.) This should probably also be backported to the 2.40 branch to keep the latest released GNU tools building with the latest released GNU tools.