From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id C3E633850626 for ; Mon, 12 Dec 2022 17:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3E633850626 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2d.google.com with SMTP id r72so300931iod.5 for ; Mon, 12 Dec 2022 09:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=tk0Gu04Gpx+HTfTyo24747I5M58DHenPz9/nxJvMzR0=; b=VStnoDft/9KihGNVQrTL07tblGwxrrChkzYWPPUJR+a1VateKLu1nMN8iydCduVYhv PGk/67vLFfOubaK6xe+KSLnpTbdNgW0SU71LpNe4XmfolSfJD54UndjrlN6h3cix4FKl ZLK3sq8vbBK9IVvHTcg5aG3fSQaVVe8WyqYTGc/P34+407vl3iJ1a+ACS+b9fSFC7AvE 3hgNrlEbsftxS6ucEGJDHHrobGZmglj6qSPhmmByhj0oSKyz8UHwtxtvKHxx4cUK3FFT Mhyg5fxGwsFdt0wTlq5gybbtM0FmtLlfsLXCwjtYFbtUFTXcdIzIchOGaTK9LJvQMowR 7HEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tk0Gu04Gpx+HTfTyo24747I5M58DHenPz9/nxJvMzR0=; b=tJdYKbR0w4hGHRkU1UAkQ86+DyUA6MuQAtQh61jloC/i8GbqYOGIg7/+IuEya0lrYS 5a642Dz1Uc0XidNAQQ/ZZVYgdmzoKaLM8x2AvaZIkoTLVOotg5coNu63bo4mBqu9aeGW cRo+r+Pons0LFQ0VCDto2HpPgvcxQFoX0cgsudrv+8aszbZlSB9nJZrZt8LWlPxeROR4 v22jT30Z+d6i292TFMoETKK1k+qDycJ8pC9tPSg4gpykWk255Hp4dyU6Yg/gslA6PDYA b8z8EM0f+fZsClX4RFk2mSkpqWAQMgmSjPmPqFaTFM3oU36Pki4Nv2jabaeNmvJubV33 k+aQ== X-Gm-Message-State: ANoB5pnw4WGJrM62LvEZ9/bRN79sB6DvofQguUwLSSKHpx22Fjr9snzF wkXPMUykGd+j04li6l/r4jUF8Q== X-Google-Smtp-Source: AA0mqf5DgqPHJ/KCjMyQUfe6KFjcqfdNOPA0s3CJSaiRr28tZUoAU60uxDr56DNL95VFFUzq9g0yBg== X-Received: by 2002:a6b:4118:0:b0:6dc:30bd:ed81 with SMTP id n24-20020a6b4118000000b006dc30bded81mr9102289ioa.20.1670866184043; Mon, 12 Dec 2022 09:29:44 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id l132-20020a6b3e8a000000b006e2d21ab686sm4258346ioa.38.2022.12.12.09.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 09:29:43 -0800 (PST) From: Tom Tromey To: Jon Turney Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH 0/3] Fix Windows C-c handling References: <20221205185651.2704492-1-tromey@adacore.com> <87wn75k770.fsf@tromey.com> X-Attribution: Tom Date: Mon, 12 Dec 2022 10:29:42 -0700 In-Reply-To: (Jon Turney's message of "Mon, 12 Dec 2022 13:23:57 +0000") Message-ID: <87zgbsfs3d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Jon" == Jon Turney writes: Jon> On 05/12/2022 18:59, Tom Tromey wrote: Tom> This series attempts to fix C-c handling on Windows, which was broken Tom> by target async. >> Jon, would you mind testing this on Cygwin? I can't really do that, >> but >> I'd rather not break the build again. >> The branch is in my github as 'submit/windows-c-c', which may be >> more >> convenient than applying via email. Jon> Thanks. Jon> This compiles ok, and seems to work. Thanks for trying it. Jon> I'm sure how, since my theory was that Cygwin should continue to use Jon> GenerateConsoleCtrlEvent() on the inferior, which would then Jon> experience a SIGINT in the Cygwin runtime, and gdb gets told about Jon> that emulated signal and stops the inferior. Jon> (In practice, I don't think that reliably worked before, and I have Jon> precisely zero time to look into this currently, so go ahead...) I don't know either :) If it works for you then that seems pretty good; and we can always change the Cygwin code paths later if need be. Tom