From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 9CD5B3852201 for ; Wed, 30 Nov 2022 15:45:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CD5B3852201 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd36.google.com with SMTP id e189so12572457iof.1 for ; Wed, 30 Nov 2022 07:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EXPaScRCmb3acvSoPb5x1zrSfe9/s7gP4P9DF6t0xXE=; b=SO9wBkR99XygdtoJQ23ZZRoqgcxbwr0h1j9mzmD2aZsqNLxh/knVwDe6k/y07pvKR8 NfpjJviGWdBnx7O0YQ0M56XqeKLS6X7YU0RzhBiHel9Nbhplxte0ZYsxddXkbY/O1MDw 0jLQpb5/tG7nHRT+gxoxydRh3ssGQJUCCSKWK6A0K1G/MCPO8H4cRxJwUNrYq9L1klfq 3/aLh1hGlpcNBXj3m4sALFyz7SOU7tD/ApCS/U56BEAdHqKFKrQLSBhM7a/3wwihi3od rRKG0wPZ1guV/FbyEDErF6d1naf66uDWkdCkeUqvJlVb7lGgoELKwvJE0M90MFh/axUC Nb7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXPaScRCmb3acvSoPb5x1zrSfe9/s7gP4P9DF6t0xXE=; b=ObVn4vpWBHW/kk6/5oXT7qCo/9+Df1CaPv6R6Wk86WZPkCLBKXwNW7gCsrykTXRkKj pAZVwEfaTAZeAhDFJDVSB+ji2nAR8Usrc0vYHloI6KlCZHqn1u+z7a9PULDL4gIOQXRc qFpjNPZMvlvmAHLd6CYE2xV9reeGqiqA29iwphqVgZAdFL43bXbQ+wQIUEy2TiNYLr+F 97AgpFfM6ioh8TNa5/fwCTjJfNgEznFmWfiF8BgU2Bd0cDDNlzI/TkpZM/DCkeMmail8 +x9xyG3Yr61twrdeqsQpWjOM49QRoEXcSsl9gwSMuO0JlhE/nxg0TFbRB5I751DGKcUi nOqQ== X-Gm-Message-State: ANoB5pmiSDMnnQXR0KRBi0RhjsdcATJIVLSwWBosRehQSromG41mnqju uzmc3UvQgIXBX1nXvDgmwOftVw== X-Google-Smtp-Source: AA0mqf4ZTpAUSWVgIyuhs346ZQ3/+7cr6DZDxbYJmznG/dJgmPuvhpBnO20gCtxyGwLOLgkbinJW6w== X-Received: by 2002:a02:84e2:0:b0:389:dd60:745d with SMTP id f89-20020a0284e2000000b00389dd60745dmr8594371jai.96.1669823124809; Wed, 30 Nov 2022 07:45:24 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id f17-20020a056602089100b006df10f981a2sm661907ioz.6.2022.11.30.07.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 07:45:23 -0800 (PST) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Bounds check access to Ada task state names References: <20221116210011.198094-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 30 Nov 2022 08:45:23 -0700 In-Reply-To: <20221116210011.198094-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 16 Nov 2022 14:00:11 -0700") Message-ID: <87zgc8mooc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> While looking into Ada tasking a little, I noticed that no bounds Tom> checking is done on accesses to the Ada task state names arrays. This Tom> isn't a problem currently, but if the runtime ever added numbers -- or Tom> if there was some kind of runtime corruption -- it could cause a gdb Tom> crash. Tom> This patch adds range checking. It also adds a missing _() call when Tom> printing from the 'task_states' array. I'm checking this in now. Tom