From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D67A63858D3C for ; Tue, 11 Oct 2022 10:34:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D67A63858D3C Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-382-3M2h9rVRMQu21lNjAK4lFg-1; Tue, 11 Oct 2022 06:34:39 -0400 X-MC-Unique: 3M2h9rVRMQu21lNjAK4lFg-1 Received: by mail-wr1-f69.google.com with SMTP id g4-20020adfbc84000000b0022fc417f87cso1832560wrh.12 for ; Tue, 11 Oct 2022 03:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Gc2sUgly8Ugmr03LR6Wrn8uC+MyOy1eI4iBBcbIe/M=; b=sU52la5YrVvCSzR5CIbRM6QQqg+FAWd9oRfW8spiRqEkZbkrP//rZGcn/C4fTJlN0/ tgvhV77xbOBeKBFvY8D07HrTnZLkNVg0rzoVQVw46oz4R46hrhhjM4xN8rs5Cwh3bG8z thBNMpRN7qHTJoZrYfu5NaxOo6Y3lRAGU/7NVlBsc6wQC7ndBlWVBta2TzwC6FC1e82V rTuProtkviCh1KEVt1KSjx6u0r5CH9l8D0dEEzAUtC+xKTB81Lo9c2aAmTYg0SBA4xjU /beGuqyCOtsEU4QQVn82MihSRZUpB8gU7wjF6/yvPgvFRnR1IbRMlL7J4r77h8MkrhUd 9EIw== X-Gm-Message-State: ACrzQf3fFeTUaNdB8O6fVvZ4iAkiquYBr+82EdI+oVkwJHl7gF9GFE0Q N1xhU5Z0JSB+5aphSXeGUTkIHhwnU+fTQugR9zAnfIvSRLMoSx5kyBEAIJgJh2IQCb93XJeSAXx iMTUSnbl3vbLzMD5r9L6sHQ== X-Received: by 2002:a05:600c:34d6:b0:3b4:91fd:cfc with SMTP id d22-20020a05600c34d600b003b491fd0cfcmr23079664wmq.1.1665484477997; Tue, 11 Oct 2022 03:34:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7EmdM2ifSMEA8ZhqNMt3zfL4SbbENoT1A//Wvp+HRwgZ6DHqXC5T0qHTXsu/glKVq0xJ8M8g== X-Received: by 2002:a05:600c:34d6:b0:3b4:91fd:cfc with SMTP id d22-20020a05600c34d600b003b491fd0cfcmr23079645wmq.1.1665484477701; Tue, 11 Oct 2022 03:34:37 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id p1-20020a5d68c1000000b0022cce7689d3sm13865769wrw.36.2022.10.11.03.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 03:34:37 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI , Tsukasa OI , Mike Frysinger , Anthony Green Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/1] sim/moxie: add custom directory stamp rule In-Reply-To: References: Date: Tue, 11 Oct 2022 11:34:36 +0100 Message-ID: <87zge2d4xv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2022 10:34:42 -0000 Tsukasa OI writes: > Because sim/moxie/moxie-gdb.dtb is neither a program nor a library, automake > does not generate dirstamp file ($builddir/sim/moxie/.dirstamp) for it. > > When maintainer mode is enabled, it tries to rebuild sim/moxie/moxie-gdb.dtb > but fails because there's no rules for automake-generated dirstamp file > which moxie-gdb.dtb depends. > > This commit adds its own rule for the directory stamp (modified copy of > the automake output) and adds the directory stamp file to DISTCLEANFILES to > mimic automake-generated behavior (although "make distclean" does not work > when maintainer mode is enabled). Thanks for doing this. I've pushed this patch with an extra comment added in local.mk (and Makefile.in regenerated). Thanks, Andrew > --- > sim/Makefile.in | 23 ++++++++++++++--------- > sim/moxie/local.mk | 5 +++++ > 2 files changed, 19 insertions(+), 9 deletions(-) > > diff --git a/sim/Makefile.in b/sim/Makefile.in > index 3278febc5e8..2d57a2bd4cc 100644 > --- a/sim/Makefile.in > +++ b/sim/Makefile.in > @@ -154,13 +154,14 @@ TESTS = testsuite/common/bits32m0$(EXEEXT) \ > @SIM_ENABLE_ARCH_m68hc11_TRUE@am__append_29 = $(m68hc11_BUILD_OUTPUTS) > @SIM_ENABLE_ARCH_mn10300_TRUE@am__append_30 = $(mn10300_BUILD_OUTPUTS) > @SIM_ENABLE_ARCH_mn10300_TRUE@am__append_31 = $(mn10300_BUILD_OUTPUTS) > -@SIM_ENABLE_ARCH_or1k_TRUE@am__append_32 = $(or1k_BUILD_OUTPUTS) > +@SIM_ENABLE_ARCH_moxie_TRUE@am__append_32 = moxie/$(am__dirstamp) > @SIM_ENABLE_ARCH_or1k_TRUE@am__append_33 = $(or1k_BUILD_OUTPUTS) > -@SIM_ENABLE_ARCH_sh_TRUE@am__append_34 = $(sh_BUILD_OUTPUTS) > -@SIM_ENABLE_ARCH_sh_TRUE@am__append_35 = sh/gencode > -@SIM_ENABLE_ARCH_sh_TRUE@am__append_36 = $(sh_BUILD_OUTPUTS) > -@SIM_ENABLE_ARCH_v850_TRUE@am__append_37 = $(v850_BUILD_OUTPUTS) > +@SIM_ENABLE_ARCH_or1k_TRUE@am__append_34 = $(or1k_BUILD_OUTPUTS) > +@SIM_ENABLE_ARCH_sh_TRUE@am__append_35 = $(sh_BUILD_OUTPUTS) > +@SIM_ENABLE_ARCH_sh_TRUE@am__append_36 = sh/gencode > +@SIM_ENABLE_ARCH_sh_TRUE@am__append_37 = $(sh_BUILD_OUTPUTS) > @SIM_ENABLE_ARCH_v850_TRUE@am__append_38 = $(v850_BUILD_OUTPUTS) > +@SIM_ENABLE_ARCH_v850_TRUE@am__append_39 = $(v850_BUILD_OUTPUTS) > subdir = . > ACLOCAL_M4 = $(top_srcdir)/aclocal.m4 > am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \ > @@ -935,13 +936,13 @@ CLEANFILES = common/version.c common/version.c-stamp \ > testsuite/common/bits-gen testsuite/common/bits32m0.c \ > testsuite/common/bits32m31.c testsuite/common/bits64m0.c \ > testsuite/common/bits64m63.c > -DISTCLEANFILES = > +DISTCLEANFILES = $(am__append_32) > MOSTLYCLEANFILES = core $(am__append_5) site-sim-config.exp \ > testrun.log testrun.sum $(am__append_7) $(am__append_10) \ > $(am__append_12) $(am__append_15) $(am__append_17) \ > $(am__append_19) $(am__append_21) $(am__append_24) \ > $(am__append_26) $(am__append_29) $(am__append_31) \ > - $(am__append_33) $(am__append_36) $(am__append_38) > + $(am__append_34) $(am__append_37) $(am__append_39) > AM_CFLAGS = $(WERROR_CFLAGS) $(WARN_CFLAGS) > AM_CPPFLAGS = -I$(srcroot)/include $(SIM_INLINE) -I$(srcdir)/common > COMPILE_FOR_BUILD = $(CC_FOR_BUILD) $(AM_CPPFLAGS) $(CFLAGS_FOR_BUILD) > @@ -950,8 +951,8 @@ SIM_ALL_RECURSIVE_DEPS = common/libcommon.a $(am__append_2) \ > $(am__append_6) $(am__append_8) $(am__append_11) \ > $(am__append_13) $(am__append_16) $(am__append_18) \ > $(am__append_20) $(am__append_22) $(am__append_25) \ > - $(am__append_27) $(am__append_30) $(am__append_32) \ > - $(am__append_34) $(am__append_37) > + $(am__append_27) $(am__append_30) $(am__append_33) \ > + $(am__append_35) $(am__append_38) > common_libcommon_a_CPPFLAGS = \ > $(AM_CPPFLAGS) \ > -DSIM_COMMON_BUILD \ > @@ -2761,6 +2762,10 @@ testsuite/common/bits64m63.c: testsuite/common/bits-gen$(EXEEXT) testsuite/commo > @SIM_ENABLE_ARCH_moxie_TRUE@ echo "update the device tree blob."; \ > @SIM_ENABLE_ARCH_moxie_TRUE@ fi > > +@SIM_ENABLE_ARCH_moxie_TRUE@moxie/$(am__dirstamp): > +@SIM_ENABLE_ARCH_moxie_TRUE@ @$(MKDIR_P) moxie > +@SIM_ENABLE_ARCH_moxie_TRUE@ @: >moxie/$(am__dirstamp) > + > @SIM_ENABLE_ARCH_or1k_TRUE@or1k/mloop.c or1k/eng.h: or1k/stamp-mloop ; @true > @SIM_ENABLE_ARCH_or1k_TRUE@or1k/stamp-mloop: $(srccom)/genmloop.sh or1k/mloop.in > @SIM_ENABLE_ARCH_or1k_TRUE@ $(AM_V_GEN)$(SHELL) $(srccom)/genmloop.sh -shell $(SHELL) \ > diff --git a/sim/moxie/local.mk b/sim/moxie/local.mk > index cd57f56ee9a..137e5876f9c 100644 > --- a/sim/moxie/local.mk > +++ b/sim/moxie/local.mk > @@ -30,3 +30,8 @@ dtb_DATA = %D%/moxie-gdb.dtb > echo "tree compiler tool (dtc) is missing. Install the tool to "; \ > echo "update the device tree blob."; \ > fi > + > +%D%/$(am__dirstamp): > + @$(MKDIR_P) %D% > + @: >%D%/$(am__dirstamp) > +DISTCLEANFILES += %D%/$(am__dirstamp) > -- > 2.34.1