From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 0B0363858C83 for ; Fri, 1 Apr 2022 19:38:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B0363858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 6237410047526 for ; Fri, 1 Apr 2022 19:38:38 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id aN6Tn5xqeY8ycaN6TnhpSl; Fri, 01 Apr 2022 19:38:38 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=e+XD9Yl/ c=1 sm=1 tr=0 ts=624754be a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=nIjFx7bm-esXjb3nIRsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7tIieae34v+sqV5H73OzGBSpffHmj/QIRsc0uZ/lKdE=; b=kvXULrhy7F7dW1COQIdBnorBRU p/C2ytral76b28GLXGmK+AVeTmx8iIfR7jUCldDUQA3YIJ/xYo2GFsCfHYpuCol3xjb2VSSE4nMeM sS+dsG2C1PNQUg4ZuHbc5R6kj; Received: from 71-211-176-135.hlrn.qwest.net ([71.211.176.135]:54544 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1naN6T-003nUW-7d; Fri, 01 Apr 2022 13:38:37 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess , rupothar Subject: Re: [PATCH 3/3] gdb: add support for Fortran's ASSUMED RANK arrays References: <20220323115809.GT1212730@redhat.com> X-Attribution: Tom Date: Fri, 01 Apr 2022 13:38:36 -0600 In-Reply-To: (Andrew Burgess via Gdb-patches's message of "Wed, 23 Mar 2022 11:59:58 +0000") Message-ID: <87zgl4lhkz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.176.135 X-Source-L: No X-Exim-ID: 1naN6T-003nUW-7d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-176-135.hlrn.qwest.net (murgatroyd) [71.211.176.135]:54544 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 19:38:40 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> An alternative approach would be to make the rank value a Andrew> gdb::optional, however, this ends up adding a bunch of complexity to Andrew> the code (e.g. having to conditionally build the array to pass to Andrew> dwarf2_evaluate_property, and handling the 'rank - 1' in Andrew> resolve_dynamic_array_or_string_1) so I haven't done that, but could, Andrew> if people think that would be a better approach. I don't really have an opinion on this, but didn't want to just completely ignore it either. I did notice one oddity. Andrew> + rank = 1; Andrew> + Andrew> + for (struct type *tmp_type = TYPE_TARGET_TYPE (type); Andrew> + check_typedef (tmp_type)->code () == TYPE_CODE_ARRAY; Andrew> + tmp_type = TYPE_TARGET_TYPE (tmp_type)) Andrew> + ++rank; This loop calls check_typedef in the condition, but not when updating tmp_type. Probably the update clause should also use check_typedef. I don't know if Fortran even has typedefs, but its safe to do this. Tom