From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 54D34385842F for ; Fri, 18 Feb 2022 17:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54D34385842F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4K0fBM6zFPz1s75G; Fri, 18 Feb 2022 18:41:15 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4K0fBM5xGdz1qqkG; Fri, 18 Feb 2022 18:41:15 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id viFUd9lGEN6f; Fri, 18 Feb 2022 18:41:14 +0100 (CET) X-Auth-Info: uhRsxtaJZqKwXmO4a4k623+CmJIFhQ9LcOGsouvUSpznB58zG/jbm/NztFEJlXhx Received: from igel.home (ppp-46-244-168-216.dynamic.mnet-online.de [46.244.168.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 18 Feb 2022 18:41:14 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 32B392C3AA8; Fri, 18 Feb 2022 18:41:14 +0100 (CET) From: Andreas Schwab To: Tom Tromey via Gdb-patches Cc: Andrew Burgess , Tom Tromey Subject: Re: [PATCH] Change how "print/x" displays floating-point value References: <20220217212957.1747537-1-tromey@adacore.com> <874k4xdqwl.fsf@redhat.com> <87k0dsqg47.fsf@tromey.com> X-Yow: YOU'D cry too if it happened to YOU!! Date: Fri, 18 Feb 2022 18:41:14 +0100 In-Reply-To: <87k0dsqg47.fsf@tromey.com> (Tom Tromey via Gdb-patches's message of "Fri, 18 Feb 2022 09:44:24 -0700") Message-ID: <87zgmovzr9.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 17:41:19 -0000 On Feb 18 2022, Tom Tromey via Gdb-patches wrote: > diff --git a/gdb/NEWS b/gdb/NEWS > index 9da74e71796..544efa3fe74 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -97,6 +97,12 @@ show style disassembler enabled > > * Changed commands > > +print > + Printing of floating-point values with base-modifying formats like > + /x has been changed to display the underlying bytes of the value in > + the desired base. This was GDB's documented behavior, but was never > + implemented correctly. How does that handle padding? > diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp > index 37632985a07..78a2147017d 100644 > --- a/gdb/testsuite/gdb.base/printcmds.exp > +++ b/gdb/testsuite/gdb.base/printcmds.exp > @@ -158,8 +158,14 @@ proc test_float_rejected {} { > # Regression test for PR gdb/21675 > proc test_radices {} { > gdb_test "print/o 16777211" " = 077777773" > - gdb_test "print/d 1.5" " = 1" > - gdb_test "print/u 1.5" " = 1" > + > + # See PR gdb/16242 for this. > + gdb_test "print/d 1.5f" " = 1069547520" > + gdb_test "print/u 1.5f" " = 1069547520" > + gdb_test "print/x 1.5f" " = 0x3fc00000" > + gdb_test "print/t 1.5f" " = 111111110000000000000000000000" > + gdb_test "print/o 1.5f" " = 07760000000" That assumes a particular representation of the float type that depends on the target. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."