From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 5325B3858D1E for ; Thu, 10 Feb 2022 21:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5325B3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id B44C610048BBE for ; Thu, 10 Feb 2022 21:13:31 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IGktnbVeHwm8iIGktnbyyy; Thu, 10 Feb 2022 21:13:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=62057ffb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oGFeUVbbRNcA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=uPI0LHNgvxolaNHKFTsA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=twIsdqID+01/SvK5jEFCmtkiB3RYjDZfvB8UcRjc3h8=; b=AOYOR1Soiqv8HMBXiAai6Q085T JFz1gCuPIzyd49ycrFhaEyD7+OqTPuxMbYRlv3IJmWlGLzEY7yFkg5YWVe8iNZa3YeUPHfJqWK8A7 OXxsE387EmLdyu/p2H//+ltJT; Received: from 75-166-128-165.hlrn.qwest.net ([75.166.128.165]:55996 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nIGks-0044pH-Rc; Thu, 10 Feb 2022 14:13:30 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess , Andrew Burgess Subject: Re: [PATCHv4 1/2] gdb: use python to colorize disassembler output References: <86d0d26c4014126e489e580b271996437e06aa39.1641911175.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 10 Feb 2022 14:13:30 -0700 In-Reply-To: <86d0d26c4014126e489e580b271996437e06aa39.1641911175.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 11 Jan 2022 14:31:00 +0000") Message-ID: <87zgmys9vp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.128.165 X-Source-L: No X-Exim-ID: 1nIGks-0044pH-Rc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-128-165.hlrn.qwest.net (murgatroyd) [75.166.128.165]:55996 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 21:13:33 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> In this commit I make use of the Python Pygments package to provide Andrew> the styling. I did investigate making use of libsource-highlight, Andrew> however, I found the highlighting results to be inferior to those of Andrew> Pygments; only some mnemonics were highlighted, and highlighting of Andrew> register names such as r9d and r8d (on x86-64) was incorrect. I think it only really handles x86. I like this patch and think it should go in. I found one nit. Also, what's up with the libopcodes-based colorizing? That seemed promising to me. Andrew> + gdbpy_enter enter_py (get_current_arch (), current_language); I think the parameters here can be removed. Tom