public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as unittest
Date: Tue, 19 Oct 2021 12:09:09 -0600	[thread overview]
Message-ID: <87zgr4x4xm.fsf@tromey.com> (raw)
In-Reply-To: <20210911120254.GA19083@delia.home> (Tom de Vries via Gdb-patches's message of "Sat, 11 Sep 2021 14:02:56 +0200")

Tom> [gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as unittest

Thanks for doing this.

Tom> +#if GDB_SELF_TEST
Tom> +namespace selftests {
Tom> +extern void (*hook_set_active_ext_lang) (void);
Tom> +void (*hook_set_active_ext_lang) (void) = nullptr;

Shouldn't need the "(void)" any more, just "()" should be ok.

It seems weird that both a declaration and definition are needed.
I guess it's a compiler issue though.

Tom>  #if GDB_SELF_TEST
Tom>  namespace selftests {
 
Tom> +extern void (*hook_set_active_ext_lang) (void);

I suppose it's hard to stick this declaration somewhere else.

Tom> +
Tom> +static void
Tom> +raise_sigint (void)

The (void) thing again, though this could also just be a tiny lambda in
the code as well.

Tom

  parent reply	other threads:[~2021-10-19 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 12:02 Tom de Vries
2021-09-22 10:17 ` Tom de Vries
2021-10-07 14:36   ` [PING][PATCH][gdb/testsuite] " Tom de Vries
2021-10-19 18:10   ` [PATCH][gdb/testsuite] " Tom Tromey
2021-10-19 22:00     ` Tom de Vries
2021-10-19 18:09 ` Tom Tromey [this message]
2021-10-19 21:56   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgr4x4xm.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).