From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: "abdul.b.ijaz" <abijaz@ecsmtp.iul.intel.com>,
abdul.b.ijaz@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/1] gdb: Fix arrays of variable length strings for FORTRAN
Date: Mon, 23 Aug 2021 14:54:53 -0600 [thread overview]
Message-ID: <87zgt7990i.fsf@tromey.com> (raw)
In-Reply-To: <20210820155247.GA2581@embecosm.com> (Andrew Burgess's message of "Fri, 20 Aug 2021 16:52:47 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> case TYPE_CODE_ARRAY:
>> + case TYPE_CODE_STRING:
>> c_value_print_array (val, stream, recurse, options);
>> break;
Andrew> I don't understand what part this change plays in this patch. I can
Andrew> see below how you're now creating values with TYPE_CODE_STRING instead
Andrew> of TYPE_CODE_ARRAY, but then I'd expect these to be covered by the
Andrew> existing handling of TYPE_CODE_STRING in
Andrew> f_language::value_print_inner.
I wonder if this should go in generic_value_print instead.
Tom
next prev parent reply other threads:[~2021-08-23 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 11:06 [PATCH 0/1] Fix variable length strings array " abdul.b.ijaz
2021-08-20 11:06 ` [PATCH 1/1] gdb: Fix arrays of variable length strings " abdul.b.ijaz
2021-08-20 15:52 ` Andrew Burgess
2021-08-23 8:47 ` Ijaz, Abdul B
2021-08-25 8:36 ` Andrew Burgess
2021-08-27 9:11 ` Ijaz, Abdul B
2021-08-23 20:54 ` Tom Tromey [this message]
2021-08-25 8:56 ` Andrew Burgess
2021-08-27 17:02 ` Tom Tromey
2021-12-29 11:31 ` Ijaz, Abdul B
2022-04-11 14:51 ` Ijaz, Abdul B
2022-04-15 16:33 ` Tom Tromey
2021-08-20 17:02 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgt7990i.fsf@tromey.com \
--to=tom@tromey.com \
--cc=abdul.b.ijaz@intel.com \
--cc=abijaz@ecsmtp.iul.intel.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).