From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ptype/o bug with "<no data fields>"
Date: Thu, 22 Apr 2021 07:17:16 -0600 [thread overview]
Message-ID: <87zgxq8nmr.fsf@tromey.com> (raw)
In-Reply-To: <20210422093100.GM2610@embecosm.com> (Andrew Burgess's message of "Thu, 22 Apr 2021 10:31:00 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> gdb/ChangeLog
>> 2021-04-21 Tom Tromey <tom@tromey.com>
>>
>> * c-typeprint.c (c_type_print_base_struct_union): Use
>> print_spaces_filtered_with_print_options.
>>
>> gdb/testsuite/ChangeLog
>> 2021-04-21 Tom Tromey <tom@tromey.com>
>>
>> * gdb.base/ptype-offsets.cc (struct empty_member): New.
>> (main): Use empty_member.
>> * gdb.base/ptype-offsets.exp: Add new test.
Andrew> LGTM.
Thanks. I think I'll hold this one until the other ptype/o patches
land.
Tom
next prev parent reply other threads:[~2021-04-22 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 1:49 Tom Tromey
2021-04-22 9:31 ` Andrew Burgess
2021-04-22 13:17 ` Tom Tromey [this message]
2021-04-22 21:45 ` Lancelot SIX
2021-04-23 1:39 ` Tom Tromey
2021-04-23 6:12 ` Eli Zaretskii
2021-04-23 10:41 ` Lancelot SIX
2021-04-23 11:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgxq8nmr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).