* [PATCH] Fix erroneous agent expression test
@ 2020-12-22 18:00 Tom Tromey
2021-01-09 17:03 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2020-12-22 18:00 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Testing of the expression rewrite revealed a buglet in ax.exp. One
test does:
gdb_test "maint agent (unsigned char)1L" ".*ext 8.*"
However, zero extension is not actually needed in this case -- a
simple "const8 1" is also correct here.
This patch changes the test to look for a push of any width of the
constant 1.
gdb/testsuite/ChangeLog
2020-12-22 Tom Tromey <tom@tromey.com>
* gdb.trace/ax.exp: Do not require an "ext".
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.trace/ax.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.trace/ax.exp b/gdb/testsuite/gdb.trace/ax.exp
index b9e65d8cf2f..6f196a197f2 100644
--- a/gdb/testsuite/gdb.trace/ax.exp
+++ b/gdb/testsuite/gdb.trace/ax.exp
@@ -86,7 +86,7 @@ gdb_test "maint agent &gdb_long_test == &gdb_short_test" ""
gdb_test "maint agent &gdb_long_test < &gdb_short_test" ""
-gdb_test "maint agent (unsigned char)1L" ".*ext 8.*"
+gdb_test "maint agent (unsigned char)1L" ".*const.* 1.*"
# Now test eval version of agent expressions.
--
2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix erroneous agent expression test
2020-12-22 18:00 [PATCH] Fix erroneous agent expression test Tom Tromey
@ 2021-01-09 17:03 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2021-01-09 17:03 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> gdb/testsuite/ChangeLog
Tom> 2020-12-22 Tom Tromey <tom@tromey.com>
Tom> * gdb.trace/ax.exp: Do not require an "ext".
I'm checking this in now.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-09 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 18:00 [PATCH] Fix erroneous agent expression test Tom Tromey
2021-01-09 17:03 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).