From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Make range types inherit signed-ness from base type
Date: Sat, 17 Oct 2020 11:42:19 -0600 [thread overview]
Message-ID: <87zh4kda10.fsf@tromey.com> (raw)
In-Reply-To: <28055f84-c81a-9e13-2719-fe3aea8313ff@simark.ca> (Simon Marchi's message of "Sat, 3 Oct 2020 21:59:38 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> On 2020-08-22 5:07 p.m., Tom Tromey wrote:
>> I ran across this comment in valprint.c:
>>
>> /* FIXME: create_static_range_type does not set the unsigned bit in a
>> range type (I think it probably should copy it from the target
>> type), so we won't print values which are too large to
>> fit in a signed integer correctly. */
>>
>> It seems to me that a range type ought to inherit its signed-ness from
>> the underlying type, so this patch implements this change, and removes
>> the comment. (It was also copied into m2-valprint.c.)
>>
>> I also remove the comment about handling ranges of enums, because I
>> think that comment is incorrect.
Simon> This looks OK to me, although I have to admit I don't really understand
Simon> the impact.
Thanks. I re-regression-tested this, and I'm checking it in now.
Tom
next prev parent reply other threads:[~2020-10-17 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 21:07 Tom Tromey
2020-10-04 1:59 ` Simon Marchi
2020-10-17 17:42 ` Tom Tromey [this message]
2020-10-19 15:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh4kda10.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).