From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Speed up psymbol reading by removing a copy
Date: Fri, 08 May 2020 14:15:18 -0600 [thread overview]
Message-ID: <87zhaip4ix.fsf@tromey.com> (raw)
In-Reply-To: <87tv1gj0c4.fsf@tromey.com> (Tom Tromey's message of "Sat, 18 Apr 2020 09:11:07 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> I noticed that cp_canonicalize_string and friends copy a
Tom> unique_xmalloc_ptr to a std::string. However, this copy isn't
Tom> genuinely needed anywhere, and it serves to slow down DWARF psymbol
Tom> reading.
Tom> This patch removes the copy and updates the callers to adapt.
Tom> This speeds up the reader from 1.906 seconds (mean of 10 runs, of gdb
Tom> on a copy of itself) to 1.888 seconds (mean of 10 runs, on the same
Tom> copy as the first trial).
Tom> I didn't notice at the time, but this message didn't include the entire
Tom> patch. I've appended the full patch now.
I'm checking this in now.
Tom
next prev parent reply other threads:[~2020-05-08 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 19:35 Tom Tromey
2020-04-18 15:11 ` Tom Tromey
2020-05-08 20:15 ` Tom Tromey [this message]
2020-05-09 18:18 ` [committed][gdb] Fix catch throw regexp matching Tom de Vries
2020-05-11 16:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhaip4ix.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).