From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125176 invoked by alias); 25 Apr 2019 18:50:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125168 invoked by uid 89); 25 Apr 2019 18:50:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:503 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 18:50:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7BA66117066; Thu, 25 Apr 2019 14:50:08 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hH7f8y0WImZD; Thu, 25 Apr 2019 14:50:08 -0400 (EDT) Received: from murgatroyd (97-122-168-123.hlrn.qwest.net [97.122.168.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 4E692116F74; Thu, 25 Apr 2019 14:50:06 -0400 (EDT) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] Fix memory leak in exception code References: <20190425165256.31226-1-tromey@adacore.com> <20190425165256.31226-6-tromey@adacore.com> <30e99361-c252-53e2-ec7c-5a6bc7301a3f@redhat.com> <87ef5qaqyn.fsf@tromey.com> <874l6m9btt.fsf@tromey.com> <1ee639e5-d431-4e79-63f4-0bf167790168@redhat.com> Date: Thu, 25 Apr 2019 18:50:00 -0000 In-Reply-To: <1ee639e5-d431-4e79-63f4-0bf167790168@redhat.com> (Pedro Alves's message of "Thu, 25 Apr 2019 19:38:37 +0100") Message-ID: <87zhod9axu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00551.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> It seemed better than adding a global, thinking about threads, but now Pedro> that I think a bit more about it, I realize that we won't ever be Pedro> able to have multiple threads call into readline simultaneously -- it's Pedro> full of global state. So I'm fine with your patch as is, afterall. Alright, I'll check in that version, after making the tweaks you requested. thanks, Tom