From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70973 invoked by alias); 9 Jun 2018 22:12:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70956 invoked by uid 89); 9 Jun 2018 22:12:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:854, simonmarchipolymtlca, simon.marchi@polymtl.ca, D*ca X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.147) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Jun 2018 22:12:38 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 4997A400C80DB for ; Sat, 9 Jun 2018 17:12:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Rm69fYqU0SjJARm69f8JiJ; Sat, 09 Jun 2018 17:12:37 -0500 X-Authority-Reason: nr=8 Received: from 75-166-19-45.hlrn.qwest.net ([75.166.19.45]:37154 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fRm69-001NW5-28; Sat, 09 Jun 2018 17:12:37 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Remove use of queue.h from gdbserver/event-loop.c References: <20180608025541.14560-1-tom@tromey.com> Date: Sat, 09 Jun 2018 22:12:00 -0000 In-Reply-To: (Simon Marchi's message of "Sat, 09 Jun 2018 08:42:09 -0400") Message-ID: <87zi037gob.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fRm69-001NW5-28 X-Source-Sender: 75-166-19-45.hlrn.qwest.net (bapiya) [75.166.19.45]:37154 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00250.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2018-06-07 22:55, Tom Tromey wrote: >> This removes a use of queue.h from gdbserver/event-loop.c, replacing >> it with std::queue. >> >> I was not completely sure whether std::queue is even that useful. >> Perhaps plain std::list could be used just as easily. Simon> In the end it probably compiles down to the same thing, since Simon> std::queue is just a wrapper around the underlying container. The Simon> std::queue would probably be useful if we wanted to swap the Simon> underlying container type without changing the code that uses the Simon> queue. I'm fine either way. In this particular case, I think any future change to the data structure is likely to be pretty easy even without the queue wrapper. Tom