From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR gdb/23210] Unset gdbarch significant_addr_bit by default
Date: Fri, 25 May 2018 18:44:00 -0000 [thread overview]
Message-ID: <87zi0n1sti.fsf@redhat.com> (raw)
In-Reply-To: <1527023088-10837-1-git-send-email-omair.javaid@linaro.org> (Omair Javaid's message of "Wed, 23 May 2018 02:04:48 +0500")
On Tuesday, May 22 2018, Omair Javaid wrote:
> This patch fixes a bug introduced by fix to AArch64 pointer tagging.
>
> In our fix for tagged pointer support our agreed approach was to sign
> extend user-space address after clearing tag bits. This is not same
> for all architectures and this patch allows sign extension for
> addresses on targets which specifically set significant_addr_bit.
>
> More information about patch that caused the issues and discussion
> around tagged pointer support can be found in links below:
>
> https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
> https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html
FWIW, I've tested your patch locally and it fixes the timeout issues
I've been seeing when debugging 32-bit binaries with a 64-bit GDB.
Thanks.
> gdb/ChangeLog:
>
> 2018-05-23 Omair Javaid <omair.javaid@linaro.org>
>
> * gdbarch.c (verify_gdbarch): Update.
> * utils.c (address_significant): Update.
> ---
> gdb/gdbarch.c | 3 +--
> gdb/utils.c | 5 +++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c
> index c430ebe..5593911 100644
> --- a/gdb/gdbarch.c
> +++ b/gdb/gdbarch.c
> @@ -615,8 +615,7 @@ verify_gdbarch (struct gdbarch *gdbarch)
> /* Skip verify of stabs_argument_has_addr, invalid_p == 0 */
> /* Skip verify of convert_from_func_ptr_addr, invalid_p == 0 */
> /* Skip verify of addr_bits_remove, invalid_p == 0 */
> - if (gdbarch->significant_addr_bit == 0)
> - gdbarch->significant_addr_bit = gdbarch_addr_bit (gdbarch);
> + /* Skip verify of significant_addr_bit, invalid_p == 0 */
> /* Skip verify of software_single_step, has predicate. */
> /* Skip verify of single_step_through_delay, has predicate. */
> /* Skip verify of print_insn, invalid_p == 0 */
> diff --git a/gdb/utils.c b/gdb/utils.c
> index 9c5bf68..91c0f2b 100644
> --- a/gdb/utils.c
> +++ b/gdb/utils.c
> @@ -2708,10 +2708,11 @@ address_significant (gdbarch *gdbarch, CORE_ADDR addr)
> /* Clear insignificant bits of a target address and sign extend resulting
> address, avoiding shifts larger or equal than the width of a CORE_ADDR.
> The local variable ADDR_BIT stops the compiler reporting a shift overflow
> - when it won't occur. */
> + when it won't occur. Skip updating of target address if current target has
> + not set gdbarch significant_addr_bit. */
> int addr_bit = gdbarch_significant_addr_bit (gdbarch);
>
> - if (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT))
> + if (addr_bit && (addr_bit < (sizeof (CORE_ADDR) * HOST_CHAR_BIT)))
> {
> CORE_ADDR sign = (CORE_ADDR) 1 << (addr_bit - 1);
> addr &= ((CORE_ADDR) 1 << addr_bit) - 1;
> --
> 2.7.4
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2018-05-25 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 21:43 Omair Javaid
2018-05-23 11:36 ` Joel Brobecker
2018-05-25 17:29 ` Omair Javaid
2018-05-25 18:02 ` Pedro Alves
2018-05-25 18:44 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi0n1sti.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).