From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12893 invoked by alias); 18 May 2018 19:29:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12881 invoked by uid 89); 18 May 2018 19:29:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=plays, sk:psymtab, H*f:sk:87in7mg, unfortunate X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 19:29:37 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 3B396311C9 for ; Fri, 18 May 2018 14:29:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Jl4Kfvi6WBcCXJl4KfrKBd; Fri, 18 May 2018 14:29:36 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:53318 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fJl4J-003MMQ-VY; Fri, 18 May 2018 14:29:36 -0500 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: time to release soon? GDB 8.1.1 release 2018-05-14 update References: <20180514173437.qxprogf7a3c56x4i@adacore.com> <87in7mgvh2.fsf@tromey.com> <20180517172317.rtfaa3aoluse3gtd@adacore.com> <87r2ma2csw.fsf@tromey.com> <20180518190017.7drpbrzmfg5h76pt@adacore.com> Date: Fri, 18 May 2018 19:50:00 -0000 In-Reply-To: <20180518190017.7drpbrzmfg5h76pt@adacore.com> (Joel Brobecker's message of "Fri, 18 May 2018 12:00:17 -0700") Message-ID: <87zi0wg3ts.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fJl4J-003MMQ-VY X-Source-Sender: 174-29-44-154.hlrn.qwest.net (pokyo) [174.29.44.154]:53318 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00413.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> If the DWARF reader patch goes in 8.1, then I will do that. >> Otherwise I probably won't. I'm not very concerned about -readnow; I >> think pretty much only gdb developers use it or should use it. Joel> OK with me. But wouldn't the issue surface as well without -readnow, Joel> when expanding the partial symtab? In theory it shouldn't. The way this works is that psymtab.c:psymtab_to_symtab, and other such functions, should not try to expand a psymtab coming from a partial CU (that both of these things are called "partial" is unfortunate). Instead, these functions find the canonical user and expand that instead, like: /* If it is a shared psymtab, find an unshared psymtab that includes it. Any such psymtab will do. */ while (pst->user != NULL) pst = pst->user; -readnow wasn't obeying this rule. The fix isn't in psymtab.c, though, because dwarf2read plays a little game to pretend that it is using the index with -readnow, because in this mode there's no reason to make a psymtab at all. Maybe should still patch psym_expand_all_symtabs, but only DWARF is using this feature, so there didn't seem to be a reason. Joel> Regarding the DWARF reader patch, I'd say we put it in 8.1.1. Ok, I will backport it next week. Tom