public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Tom Tromey <tom@tromey.com>,
	 "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
Subject: Re: [RFA 6/6] Remove long_long_align_bit gdbarch attribute
Date: Thu, 26 Apr 2018 20:56:00 -0000	[thread overview]
Message-ID: <87zi1p660z.fsf@tromey.com> (raw)
In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B1358A23CD3@DE02WEMBXB.internal.synopsys.com>	(Anton Kolesov's message of "Tue, 24 Apr 2018 17:16:21 +0000")

>>>>> "Anton" == Anton Kolesov <Anton.Kolesov@synopsys.com> writes:

Anton> I would have implemented this as:

Anton> static ULONGEST
Anton> arc_type_align (struct gdbarch *gdbarch, struct type *type) {
Anton>   type = check_typedef (type);
Anton>   return std::min<ULONGEST>(4, TYPE_LENGTH (type));
Anton> }

Thanks, I've made this change locally.

Tom

  reply	other threads:[~2018-04-26 20:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:22 [RFA 0/6] Teach gdb about type alignment Tom Tromey
2018-04-24 15:22 ` [RFA 1/6] Add initial type alignment support Tom Tromey
2018-04-24 19:16   ` Pedro Alves
2018-04-24 20:23     ` Tom Tromey
2018-04-24 15:22 ` [RFA 6/6] Remove long_long_align_bit gdbarch attribute Tom Tromey
2018-04-24 15:24   ` Tom Tromey
2018-04-24 17:17   ` Anton Kolesov
2018-04-26 20:56     ` Tom Tromey [this message]
2018-04-24 15:22 ` [RFA 3/6] Reindent type_object_getset in py-type.c Tom Tromey
2018-04-24 15:22 ` [RFA 5/6] Remove rust_type_alignment Tom Tromey
2018-04-24 15:22 ` [RFA 2/6] Handle alignof and _Alignof Tom Tromey
2018-04-24 17:04   ` Eli Zaretskii
2018-04-24 19:17   ` Pedro Alves
2018-04-24 20:23     ` Tom Tromey
2018-04-27 18:02       ` Pedro Alves
2018-04-27 20:53         ` Tom Tromey
2018-04-30 16:46         ` Tom Tromey
2018-04-26 20:45     ` Tom Tromey
2018-04-27 18:05       ` Pedro Alves
2018-04-26 20:54     ` Tom Tromey
2018-04-24 15:22 ` [RFA 4/6] Expose type alignment on gdb.Type Tom Tromey
2018-04-24 16:59   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi1p660z.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Anton.Kolesov@synopsys.com \
    --cc=Claudiu.Zissulescu@synopsys.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).