From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45088 invoked by alias); 28 Jun 2017 19:28:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45072 invoked by uid 89); 28 Jun 2017 19:28:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=Hx-languages-length:1163 X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 19:28:03 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v5SJRuPh025867 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Jun 2017 19:27:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v5SJRtB9009755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Jun 2017 19:27:56 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v5SJRtMU022812; Wed, 28 Jun 2017 19:27:55 GMT Received: from termi.oracle.com (/10.175.206.5) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Jun 2017 12:27:55 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org, weimin.pan@oracle.com Subject: Re: File name convention ARCH-OSABI-tdep.c References: <868tklhct8.fsf@gmail.com> <774b16af-c8d7-baa7-5b67-bf4c98378da6@redhat.com> Date: Wed, 28 Jun 2017 19:28:00 -0000 In-Reply-To: <774b16af-c8d7-baa7-5b67-bf4c98378da6@redhat.com> (Pedro Alves's message of "Tue, 27 Jun 2017 14:17:06 +0100") Message-ID: <87zicr9akq.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00774.txt.bz2 > I want to extend the *-tdep.c file name convention. The current > convention is ARCH-OSABI-tdep.c, and I want to extend it to > ARCH-OSABI-tdep-FUNC.c, in which FUNC is about a certain functionality > or feature about this target. > > The sparc64 adi patch > (https://sourceware.org/ml/gdb-patches/2017-06/msg00472.html) adds a new > file sparc64-adi-tdep.c which should be merged to sparc64-tdep.c > according to the current naming convention. However, I think it is good > to put different things in different files. So with the new convention > proposed here, the new file can be sparc64-tdep-adi.c. > > Secondly, some *-tdep.c files are already quite large, arm-tdep.c is of > 399434 bytes, 13318 lines. It is the 5th largest file. arm-tdep.c > includes many things which are not related to each, like displaced > stepping and process record. I am thinking that we should allow people > moving them out of *-tdep.c to *-tdep-displaced.c and *-tdep-precord.c. > This is fine with me. I definitely agree with splitting big files in smaller pieces. Since no one objected... do we have consensus on this one? :)