From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Doug Evans <dje@google.com>,
Joel Brobecker <brobecker@adacore.com>,
Ulrich Weigand <uweigand@de.ibm.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Several regressions and we branch soon.
Date: Fri, 10 Jul 2015 16:12:00 -0000 [thread overview]
Message-ID: <87zj34j8kl.fsf@br87z6lw.de.ibm.com> (raw)
In-Reply-To: <86h9pcl5lc.fsf@gmail.com> (Yao Qi's message of "Fri, 10 Jul 2015 10:33:35 +0100")
On Fri, Jul 10 2015, Yao Qi wrote:
> Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
>
>> Subject: [PATCH] gnu_vector.exp: Skip infcall tests on x86/x86_64
>>
>> Since the new KFAILs/KPASSs for the infcall tests on x86 and x86_64
>> targets generated unnecessary noise, this change skips them with
>> UNSUPPORTED instead.
>
> Hi Andreas,
> I still see some fails in gnu_vector.exp in various architectures,
>
> Here are some fails on ppc64be-m64, as I found from buildbot
> https://www.sourceware.org/ml/gdb-testers/2015-q3/msg01198.html
>
> new FAIL: gdb.base/gnu_vector.exp: call add_some_intvecs
> new FAIL: gdb.base/gnu_vector.exp: call add_various_floatvecs
> new FAIL: gdb.base/gnu_vector.exp: finish shows vector return value
> new FAIL: gdb.base/gnu_vector.exp: verify vector return value (the program exited)
>
> Does GDB support vector infcall on ppc64be?
AFAIK, it should. However, on that system the compilation with
"-mcpu=native" fails because GCC5 emits an ABI warning:
gnu_vector.c:62:1: note: the layout of aggregates containing vectors with 4-byte alignment has changed in GCC 5
Then the test case falls back to compiling without an "-mcpu=" flag, so
the FAILs occur with GCC's default machine options. I am not sure
whether that is supposed to work with GDB. (Does anybody know?)
Anyway, maybe we should add "-Wno-psabi" to the compile options. This
will likely get rid of the (probably unimportant) FAILs above.
> I checked the test result
> on ppc64le https://www.sourceware.org/ml/gdb-testers/2015-q3/msg01201.html
> but gnu_vector.exp isn't compiled successfully (due to old gcc?) this
> case isn't compiled successfully on aix buildslave either.
GCC5 on ppc64le emits the ABI warning even in absence of "-mcpu=".
Again it should help to add "-Wno-psabi".
>
> I also see two fails on s390x from buildbot
> https://www.sourceware.org/ml/gdb-testers/2015-q3/msg00957.html
>
> FAIL: gdb.base/gnu_vector.exp: finish shows vector return value
> FAIL: gdb.base/gnu_vector.exp: verify vector return value (the program exited)
>
> IIUC, vector infcall should be supported on s390 GDB, right?
Yes. But in this case no vector ABI is used, because that test machine
does not have a vector facility and because -march=native is not
supported by GCC (yet). Thus vector return values are not passed in
vector registers, but according to RETURN_VALUE_STRUCT_CONVENTION. And
then we hit the problem that displaying such return values is not
supported by GDB: https://sourceware.org/bugzilla/show_bug.cgi?id=8549
Note that various other testsuite FAILs on s390 are due to
non-displayable structure return values as well, e.g.:
FAIL: gdb.ada/array_return.exp: value printed by finish of Create_Small
Thus I have already been working on fixing that.
> I also see some vector infcall fails on both arm and aarch64 too. What
> GDB targets should support vector infcall? ppc64 (le and be) and s390?
Sorry, I do not know. This question should better be addressed to the
various architecture maintainers. Note that many architectures have
*multiple* vector ABIs, depending on the level of hardware support
available. So a complete answer to your question would be a filled-out
table like this (where the examples are obviously completely made up):
| architecture | vector ABI | infcall | "finish" |
|--------------+------------+---------+----------|
| foo | no HW | OK | bad ret |
| | VX16 | broken | broken |
| | VY32 | OK | OK |
|--------------+------------+---------+----------|
| bar | no HW | OK | OK |
| | VBLURB | OK | OK |
| | V-ng | unsupp | no ret |
The s390 part currently looks like this:
| architecture | vector ABI | infcall | "finish" |
|--------------+---------------------+---------+----------|
| s390x | no HW | OK | no ret |
| | S390_VECTOR_ABI_128 | OK | OK |
(1) Assuming that the vector return value fits in a vector register.
> I am wondering we should only do the vector infcall tests on the
> supported GDB targets, and skip for the rest of them.
We could. On the other hand there is a difference from the usual
"lacking support" case: Normally GDB tells the user about the lacking
support. Here, GDB performs a bogus inferior function call instead,
shows a wrong return value, or even crashes the inferior. This seems
more like a bug than a missing feature to me. In my view, targets that
can not perform vector ABI infcalls correctly should at least suppress
the infcall and emit an appropriate error message.
--
Andreas
next prev parent reply other threads:[~2015-07-10 16:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 18:31 Doug Evans
2015-06-23 18:55 ` Patrick Palka
2015-06-23 19:03 ` Doug Evans
2015-06-23 20:17 ` Keith Seitz
2015-06-23 20:53 ` Doug Evans
2015-06-23 21:45 ` Patrick Palka
2015-06-24 11:55 ` Yao Qi
2015-06-25 16:35 ` Tedeschi, Walfred
2015-07-01 8:49 ` Yao Qi
[not found] ` <AC542571535E904D8E8ADAE745D60B1944445D44@IRSMSX104.ger.corp.intel.com>
2015-07-01 9:30 ` Walfred Tedeschi
2015-07-02 10:09 ` Yao Qi
2015-07-02 15:34 ` Yao Qi
2015-07-02 16:19 ` [PATCH] Don't throw an error in "show mpx bound" implementation Patrick Palka
2015-07-06 9:31 ` Yao Qi
2015-06-24 10:21 ` Several regressions and we branch soon Yao Qi
2015-06-25 8:21 ` Andreas Arnez
2015-06-25 13:34 ` Doug Evans
2015-06-25 18:00 ` Andreas Arnez
2015-06-30 15:21 ` Yao Qi
2015-06-30 18:09 ` Andreas Arnez
2015-07-01 8:01 ` Yao Qi
2015-07-10 9:33 ` Yao Qi
2015-07-10 16:12 ` Andreas Arnez [this message]
2015-07-10 16:23 ` Ulrich Weigand
2015-07-20 15:08 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj34j8kl.fsf@br87z6lw.de.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).