* "make TAGS" broken in 7.8.90
@ 2015-01-20 17:36 Eli Zaretskii
2015-01-20 17:50 ` Sergio Durigan Junior
2015-01-22 18:11 ` Eli Zaretskii
0 siblings, 2 replies; 5+ messages in thread
From: Eli Zaretskii @ 2015-01-20 17:36 UTC (permalink / raw)
To: gdb-patches; +Cc: Sergio Durigan Junior
"make TAGS" is broken. Again. (Sergio, would it make sense to add
"make TAGS" to the list of commands run by the buildbot after a build?
This breaks too often, IMO.)
Doing TAGS in gdb
make[2]: Entering directory `/d/usr/eli/utils/gdb-7.8.90/gdb'
make[2]: *** No rule to make target `ada-varobj.h', needed by `TAGS'.
make[2]: Target `TAGS' not remade because of errors.
./x86-dregs.c: No such file or directory
./irix5-nat.c: No such file or directory
ada-varobj.h and irix5-nat.c should simply be removed from the
respective lists. But I'm not sure how to fix the x86-dregs.c issue.
The problem here is that x86-dregs.o is in gdb/, but the source is in
gdb/nat/, so the simplistic editing:
done) | sed 's/\.o$$/\.c/'` \
doesn't work. Thoughts?
One other annoyance with "make TAGS" is that libdecnumber doesn't
support that target, so you must invoke the command from gdb/, or use
"make -k", otherwise it bails out. Any reason not to support TAGS in
libdecnumber?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "make TAGS" broken in 7.8.90
2015-01-20 17:36 "make TAGS" broken in 7.8.90 Eli Zaretskii
@ 2015-01-20 17:50 ` Sergio Durigan Junior
2015-01-20 18:26 ` Eli Zaretskii
2015-01-22 18:11 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Sergio Durigan Junior @ 2015-01-20 17:50 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
On Tuesday, January 20 2015, Eli Zaretskii wrote:
> "make TAGS" is broken. Again. (Sergio, would it make sense to add
> "make TAGS" to the list of commands run by the buildbot after a build?
> This breaks too often, IMO.)
Certainly. I will adjust the build to include this step. I don't use
"make TAGS" myself, so are there any dependencies that need to be
installed to run it?
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "make TAGS" broken in 7.8.90
2015-01-20 17:50 ` Sergio Durigan Junior
@ 2015-01-20 18:26 ` Eli Zaretskii
2015-01-20 22:48 ` Sergio Durigan Junior
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2015-01-20 18:26 UTC (permalink / raw)
To: Sergio Durigan Junior; +Cc: gdb-patches
> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 20 Jan 2015 12:49:56 -0500
>
> On Tuesday, January 20 2015, Eli Zaretskii wrote:
>
> > "make TAGS" is broken. Again. (Sergio, would it make sense to add
> > "make TAGS" to the list of commands run by the buildbot after a build?
> > This breaks too often, IMO.)
>
> Certainly.
Thanks.
> I will adjust the build to include this step. I don't use "make
> TAGS" myself, so are there any dependencies that need to be
> installed to run it?
The 'etags' command from Emacs is all you need. If Emacs is already
installed, then 'etags' should be on PATH, I think.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "make TAGS" broken in 7.8.90
2015-01-20 18:26 ` Eli Zaretskii
@ 2015-01-20 22:48 ` Sergio Durigan Junior
0 siblings, 0 replies; 5+ messages in thread
From: Sergio Durigan Junior @ 2015-01-20 22:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
On Tuesday, January 20 2015, Eli Zaretskii wrote:
>> I will adjust the build to include this step. I don't use "make
>> TAGS" myself, so are there any dependencies that need to be
>> installed to run it?
>
> The 'etags' command from Emacs is all you need. If Emacs is already
> installed, then 'etags' should be on PATH, I think.
Right, I added this as a step in the BuildBot. It should trigger in the
next builds.
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: "make TAGS" broken in 7.8.90
2015-01-20 17:36 "make TAGS" broken in 7.8.90 Eli Zaretskii
2015-01-20 17:50 ` Sergio Durigan Junior
@ 2015-01-22 18:11 ` Eli Zaretskii
1 sibling, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2015-01-22 18:11 UTC (permalink / raw)
To: gdb-patches; +Cc: sergiodj
> Date: Tue, 20 Jan 2015 19:34:18 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: Sergio Durigan Junior <sergiodj@redhat.com>
>
> "make TAGS" is broken. Again. (Sergio, would it make sense to add
> "make TAGS" to the list of commands run by the buildbot after a build?
> This breaks too often, IMO.)
>
> Doing TAGS in gdb
> make[2]: Entering directory `/d/usr/eli/utils/gdb-7.8.90/gdb'
> make[2]: *** No rule to make target `ada-varobj.h', needed by `TAGS'.
> make[2]: Target `TAGS' not remade because of errors.
> ./x86-dregs.c: No such file or directory
> ./irix5-nat.c: No such file or directory
>
> ada-varobj.h and irix5-nat.c should simply be removed from the
> respective lists.
I've just pushed the below as obvious.
> But I'm not sure how to fix the x86-dregs.c issue.
> The problem here is that x86-dregs.o is in gdb/, but the source is in
> gdb/nat/, so the simplistic editing:
>
> done) | sed 's/\.o$$/\.c/'` \
>
> doesn't work. Thoughts?
>
> One other annoyance with "make TAGS" is that libdecnumber doesn't
> support that target, so you must invoke the command from gdb/, or use
> "make -k", otherwise it bails out. Any reason not to support TAGS in
> libdecnumber?
Still didn't fix these. Any ideas for an elegant solution?
commit 82a864f96aff83edb0c8bb21ead5c28cd10363fe
Author: Eli Zaretskii <eliz@gnu.org>
Date: Thu Jan 22 20:05:59 2015 +0200
Partial fix for "make TAGS".
gdb/
2015-01-22 Eli Zaretskii <eliz@gnu.org>
* Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
(ALLDEPFILES): Remove irix5-nat.c. These two are part of the
reason that "make TAGS" is broken.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fee6903..06be4ed 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2015-01-22 Eli Zaretskii <eliz@gnu.org>
+
+ * Makefile.in (HFILES_NO_SRCDIR): Remove ada-varobj.h.
+ (ALLDEPFILES): Remove irix5-nat.c. These two are part of the
+ reason that "make TAGS" is broken.
+
2015-01-22 Chen Gang <gang.chen.5i5j@gmail.com>
* hppa-tdep.c (inst_saves_gr): Fix logical working flow issues
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6b270eb..8addef4 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -890,7 +890,7 @@ proc-utils.h aarch64-tdep.h arm-tdep.h ax-gdb.h ppcfbsd-tdep.h \
ppcnbsd-tdep.h cli-out.h gdb_expat.h breakpoint.h infcall.h obsd-tdep.h \
exec.h m32r-tdep.h osabi.h gdbcore.h solib-som.h amd64bsd-nat.h \
i386bsd-nat.h xml-support.h xml-tdesc.h alphabsd-tdep.h gdb_obstack.h \
-ia64-tdep.h ada-lang.h ada-varobj.h varobj.h varobj-iter.h frv-tdep.h \
+ia64-tdep.h ada-lang.h varobj.h varobj-iter.h frv-tdep.h \
nto-tdep.h serial.h \
c-lang.h d-lang.h go-lang.h frame.h event-loop.h block.h cli/cli-setshow.h \
cli/cli-decode.h cli/cli-cmds.h cli/cli-utils.h \
@@ -1666,7 +1666,6 @@ ALLDEPFILES = \
ia64-hpux-nat.c ia64-hpux-tdep.c \
ia64-linux-nat.c ia64-linux-tdep.c ia64-tdep.c ia64-vms-tdep.c \
inf-ptrace.c inf-ttrace.c \
- irix5-nat.c \
ia64-libunwind-tdep.c \
linux-fork.c \
linux-tdep.c \
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-22 18:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-20 17:36 "make TAGS" broken in 7.8.90 Eli Zaretskii
2015-01-20 17:50 ` Sergio Durigan Junior
2015-01-20 18:26 ` Eli Zaretskii
2015-01-20 22:48 ` Sergio Durigan Junior
2015-01-22 18:11 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).