From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26151 invoked by alias); 14 Jan 2014 20:25:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26087 invoked by uid 89); 14 Jan 2014 20:25:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 20:25:52 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EKPor8029487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 15:25:51 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0EKPnEc003762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 14 Jan 2014 15:25:50 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC 01/32] add "this" pointers to more target APIs References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-2-git-send-email-tromey@redhat.com> <52D52930.5060702@redhat.com> Date: Tue, 14 Jan 2014 20:25:00 -0000 In-Reply-To: <52D52930.5060702@redhat.com> (Pedro Alves's message of "Tue, 14 Jan 2014 12:10:24 +0000") Message-ID: <87zjmytinm.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00478.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> /* Unregister from the event loop. */ >> - if (linux_nat_is_async_p ()) >> - linux_nat_async (NULL, 0); >> + if (linux_nat_is_async_p (linux_ops)) >> + linux_nat_async (linux_ops, NULL, 0); Pedro> I still think linux_ops is the wrong target to Pedro> use here. I'm sorry if I missed some earlier review note of it. It wasn't intentional. Pedro> While to_close doesn't have a self Pedro> pointer, I'd suggest using NULL or adding a comment Pedro> (or storing the multi-threaded target pointer in a Pedro> global, though given the target really isn't used, Pedro> that's probably overkill). Yes, I agree. I used "NULL". The native targets are unusual because, in gdb's design, they are inherently singletons. Tom