Fix for bugzilla/16152

Fix for bugzilla/16152

[Steffen Sledz]

Please have a look at <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>.

A patch fixing this problem is attached there.

Thanx,
Steffen Sledz

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: Fix for bugzilla/16152

[Tom Tromey]

>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:

Steffen> Please have a look at
Steffen> <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>.  A
Steffen> patch fixing this problem is attached there.

We prefer patches to be submitted to the list, following the
contribution guidelines.  Could you do that instead?

Tom

[PATCH] gdb: fix cygwin check in configure script

[Steffen Sledz]

Avoids false positives if the search pattern "lose" is found in path
descriptions in comments generated by the preprocessor.

see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index 8b20a13..0edba09 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -12766,7 +12766,7 @@ lose
 #endif
 _ACEOF
 if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
-  $EGREP "lose" >/dev/null 2>&1; then :
+  $EGREP "^lose$" >/dev/null 2>&1; then :
   gdb_cv_os_cygwin=yes
 else
   gdb_cv_os_cygwin=no
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 88db73a..4d1c419 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1880,7 +1880,7 @@ AC_SUBST(WERROR_CFLAGS)
 
 # In the Cygwin environment, we need some additional flags.
 AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
-[AC_EGREP_CPP(lose, [
+[AC_EGREP_CPP(^lose$, [
 #if defined (__CYGWIN__) || defined (__CYGWIN32__)
 lose
 #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
-- 
1.8.1.4

Re: [PATCH] gdb: fix cygwin check in configure script

[Tom Tromey]

>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:

Steffen> Avoids false positives if the search pattern "lose" is found in path
Steffen> descriptions in comments generated by the preprocessor.

Steffen> see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>

This needs a ChangeLog entry.
Ok with that.

Tom

[PATCH v2] gdb: fix cygwin check in configure script

[Steffen Sledz]

Avoids false positives if the search pattern "lose" is found in path
descriptions in comments generated by the preprocessor.

see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 gdb/ChangeLog    | 5 +++++
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index aec0768..ead7874 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-24  Steffen Sledz <sledz@dresearch-fe.de>
+
+	* configure: Rebuild.
+	* configure.ac: fix cygwin detection check
+
 2013-11-24  Yao Qi  <yao@codesourcery.com>
 
 	* disasm.c (dis_asm_read_memory): Call target_read_code
diff --git a/gdb/configure b/gdb/configure
index 5514b2f..b38e183 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -12446,7 +12446,7 @@ lose
 #endif
 _ACEOF
 if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
-  $EGREP "lose" >/dev/null 2>&1; then :
+  $EGREP "^lose$" >/dev/null 2>&1; then :
   gdb_cv_os_cygwin=yes
 else
   gdb_cv_os_cygwin=no
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 9b73887..2947293 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS)
 
 # In the Cygwin environment, we need some additional flags.
 AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
-[AC_EGREP_CPP(lose, [
+[AC_EGREP_CPP(^lose$, [
 #if defined (__CYGWIN__) || defined (__CYGWIN32__)
 lose
 #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
-- 
1.8.4

Re: [PATCH v2] gdb: fix cygwin check in configure script

[Pedro Alves]

Pushed, thanks.

-- 
Pedro Alves

On 11/24/2013 12:13 PM, Steffen Sledz wrote:
> Avoids false positives if the search pattern "lose" is found in path
> descriptions in comments generated by the preprocessor.
> 
> see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  gdb/ChangeLog    | 5 +++++
>  gdb/configure    | 2 +-
>  gdb/configure.ac | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index aec0768..ead7874 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-11-24  Steffen Sledz <sledz@dresearch-fe.de>
> +
> +	* configure: Rebuild.
> +	* configure.ac: fix cygwin detection check
> +
>  2013-11-24  Yao Qi  <yao@codesourcery.com>
>  
>  	* disasm.c (dis_asm_read_memory): Call target_read_code
> diff --git a/gdb/configure b/gdb/configure
> index 5514b2f..b38e183 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -12446,7 +12446,7 @@ lose
>  #endif
>  _ACEOF
>  if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
> -  $EGREP "lose" >/dev/null 2>&1; then :
> +  $EGREP "^lose$" >/dev/null 2>&1; then :
>    gdb_cv_os_cygwin=yes
>  else
>    gdb_cv_os_cygwin=no
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index 9b73887..2947293 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS)
>  
>  # In the Cygwin environment, we need some additional flags.
>  AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
> -[AC_EGREP_CPP(lose, [
> +[AC_EGREP_CPP(^lose$, [
>  #if defined (__CYGWIN__) || defined (__CYGWIN32__)
>  lose
>  #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
> 

Re: [PATCH v2] gdb: fix cygwin check in configure script

[Steffen Sledz]

Am 27.11.2013 19:53, schrieb Pedro Alves:
> Pushed, thanks.

Great!

So someone should close the related issue[1] in the bugtracker!

Steffen

[1] <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [PATCH v2] gdb: fix cygwin check in configure script

[Tom Tromey]

>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:

Steffen> So someone should close the related issue[1] in the bugtracker!

Steffen> [1] <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>

I closed it.
FWIW it's best if you mention relevant PRs when sending the patch.

Tom