Re: [PATCH] Use thread_info and inferior pointers more throughout

[Pedro Alves <palves@redhat.com>]

On 06/25/2018 11:17 AM, Ulrich Weigand wrote:
> Pedro Alves wrote:
> 
>> 	(delete_thread, delete_thread_silent): Take a thread_info pointer
>> 	instead of a ptid.
> 
> Looks like not all callers were updated; I'm seeing build bot failures:
> 
> gdb/remote-sim.c: In member function 'virtual void gdbsim_target::mourn_inferior()':
> gdb/remote-sim.c:1198:50: error: cannot convert 'ptid_t' to 'thread_info*' for argument '1' to 'void delete_thread_silent(thread_info*)'
>    delete_thread_silent (sim_data->remote_sim_ptid);
> 
> Just from grepping, there also seem to be a number of other calls
> in native code that were not updated:
> go32-nat.c:  delete_thread_silent (ptid);
> bsd-kvm.c:  delete_thread_silent (bsd_kvm_ptid);
> darwin-nat.c:     delete_thread (ptid_build (inf->pid, 0, old_id));
> fbsd-nat.c:               delete_thread (wptid);
> aix-thread.c:     delete_thread (gbuf[gi]->ptid);
> aix-thread.c:         delete_thread (gptid);
> windows-nat.c:  delete_thread (ptid);
> procfs.c:                   delete_thread (retval);
> procfs.c:                   delete_thread (retval);

Thanks, I'll take a look.

Thanks,
Pedro Alves