From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6815 invoked by alias); 25 Jun 2018 10:23:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6805 invoked by uid 89); 25 Jun 2018 10:23:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HTo:U*uweigand X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jun 2018 10:23:02 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BD4E68801; Mon, 25 Jun 2018 10:23:00 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF8757C49; Mon, 25 Jun 2018 10:22:59 +0000 (UTC) Subject: Re: [PATCH] Use thread_info and inferior pointers more throughout To: Ulrich Weigand References: <20180625101758.0639CD801CC@oc3748833570.ibm.com> Cc: Tom Tromey , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <883171b4-02e2-83be-8fb0-af9a1d76d0b2@redhat.com> Date: Mon, 25 Jun 2018 10:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180625101758.0639CD801CC@oc3748833570.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00572.txt.bz2 On 06/25/2018 11:17 AM, Ulrich Weigand wrote: > Pedro Alves wrote: > >> (delete_thread, delete_thread_silent): Take a thread_info pointer >> instead of a ptid. > > Looks like not all callers were updated; I'm seeing build bot failures: > > gdb/remote-sim.c: In member function 'virtual void gdbsim_target::mourn_inferior()': > gdb/remote-sim.c:1198:50: error: cannot convert 'ptid_t' to 'thread_info*' for argument '1' to 'void delete_thread_silent(thread_info*)' > delete_thread_silent (sim_data->remote_sim_ptid); > > Just from grepping, there also seem to be a number of other calls > in native code that were not updated: > go32-nat.c: delete_thread_silent (ptid); > bsd-kvm.c: delete_thread_silent (bsd_kvm_ptid); > darwin-nat.c: delete_thread (ptid_build (inf->pid, 0, old_id)); > fbsd-nat.c: delete_thread (wptid); > aix-thread.c: delete_thread (gbuf[gi]->ptid); > aix-thread.c: delete_thread (gptid); > windows-nat.c: delete_thread (ptid); > procfs.c: delete_thread (retval); > procfs.c: delete_thread (retval); Thanks, I'll take a look. Thanks, Pedro Alves