From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec217.isp.belgacom.be (mailsec217.isp.belgacom.be [195.238.22.113]) by sourceware.org (Postfix) with ESMTPS id 18A573856DC2 for ; Sat, 28 May 2022 10:08:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18A573856DC2 X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2AEAQAn85Fi/yFRiNkNTYEJCYFGiUeREJxngXwLAQEBA?= =?us-ascii?q?QEBAQEBCUIEAQGFAgKFRSY1CA4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBA?= =?us-ascii?q?QYEAYEbhS+CeykBg2QBAQEDIwRiCxgCAiYCAlcGAYMPrzx6fzKBAYRugyuBZ?= =?us-ascii?q?YERLIc/gwmEGzeBVUSBFYMqPoEFAYcUgmUEljkdOwMcMjUSgSFxAQgGBgcKB?= =?us-ascii?q?TIGAgwYFAQCExFTHQITBQcKHA4UHCQZDA8DEgMRAQcCCxIIFSwIAwIDCAMCA?= =?us-ascii?q?y4CAxgJBwoDHQgKHBIQFAIEEx8LCAMaHy0JAgQOA0MICwoDEQQDExgLFggQB?= =?us-ascii?q?AYDCS8NKAsDBQ8PAQYDBgIFBQEDIAMUAwUnBwMhBwsmDQ0EHAcdAwMFJgMCA?= =?us-ascii?q?hsHAgIDAgYXBgICcQooDQgECAQcHiUTBQIHMQUELwIeBAUGEQkCFgIGBAUCB?= =?us-ascii?q?AQWAgISCAIIJxsHFhkdGQEFXQYLCSEcKQsGBQYWAyN4BQo+Dyk6BiIBHZdSc?= =?us-ascii?q?oJKTmovoWCeYTQHg1GBPQYMnj8xqFotljsgpxOBYwGCEm2DPFAojjeOO4EuA?= =?us-ascii?q?gYLAQEDCY4eAQE?= IronPort-PHdr: A9a23:kdm6rxI8EeugWUiTTNmcuAlhWUAX0o4c3iYr45Yqw4hDbr6kt8y7e hCFvrM91RSQDM3y0LFts6LuqafuWGgNs96qkUspV9hybSIDktgchAc6AcSIWgXRJf/uaDEmT owZDAc2t360PlJIF8ngelbcvmO97SIIGhX4KAF5Ovn5FpTdgsip2e2+4Z7ebxhHiDagZb55M Qm7oxjWusQKm4VpN7w/ygHOontGeuRWwX1nKFeOlBvi5cm+4YBu/T1It/0u68BPX6P6f78lT bNDFzQpL3o15MzwuhbdSwaE+2YRXX8XkhpMBAjF8Q36U5LsuSb0quZxxC+XNtDtQLsqRTqt8 btkSB7wiCcGKTE59n3Xitdth65fuR6tugBzz5LRbIyTKfFwfL7SfckCSGRCQ8hfVzJPDI2+Y IsBE+UOM+lXoYbmqlsSrxazHxWgCP/1xzJKgHL9wK000/4mEQHDxAEuBdIOsHXQrNX0LKcSS f66x7TIwjrZdfNW3i796JXJch8/u/GMRq97fM3JyUkvFgPFilSQqZT9PzyLzOgMvXKU7/BnV eK2lm4nqh9+oiK0xso3kYnJhYIUylba+iVl2oo6PsO3RVd9bNW5H5ReqzuUOJFqQsM+XW5oo iA6x6UYtZKlfyUH1JsqywLDZ/GFc4WF7Q/uWuaNLTp3i3xreK+yihi2/EW+xOPxSMe53VVJo ydLk9TBtn4A2hPX58WGTPZ240Sv2S6X2gzN9+1JI1o4mbfVJpMg2LI9lYcfvV7NEyL4nkj9k bWYeV8++uey7uTqerDmppiBOIBqkgz+KaEumtCnAeQ/LwgOQ3CX+eSi273n+k30WLFFguAyn 6XHqpzWOMUWq62jDwNIyIov9hKyADG+3NQZm3kIMk5FdQqZg4T0OVzCOu30APm+jli2kzpn2 urKM7PvD5nVK3jMirbhfbJz605GzwozyMhS54pUCrEAJPLzW1fxtMTGARMjPQ272fznCNJk1 oMDWGKAHLWZMLjJvF+T5eIuI++Ma5EJuDrnMPcq+ebijXkillAFZ6mmwYMXaGykHvRhO0iVf 2Lggs0dHmcSogo+UOvqhUWaUTFNenmyRaU86yojCI28CYfDWJ6igKeb0Ce9AJJWenhKCkqQH nfwa4WER/AMZTqdIsB8iTMITKChRJU91R6ytA/11aFnI/HP+i0fqJLjzsR66PPdlB4o7zx7E d6R02aXT2F7zSs0QGoO0axlpgRUzkmOyuAsm/FUD9t7//pNTAohc5jR07o+Q9/+UEfZd8uCS Fu9as6hHCs6Q8042dJIZFxySPu4iRWW5yqrB74Nj7HDO5Uu9bvB3nXrPI4p03bH0Kg5l1RgX cJVMnS7h6Nl7CDIBJ/Pnlnfnav8JvdU5zLE6GrWlTnGh0pfSgMlFPydBRgi IronPort-Data: A9a23:pMAHVKiluEMnOSRk6IGNV9EaX1612BIKZh0ujC45NGQN5FlHY01je htvXz/UOqqPamLyKtBwbo6//RsPsZWGzIBqQFM9qiA8FitjpJueD7x1DKtQ0wB+jyHnZBg6h ynLQoCYdKjYdleF+lH1dOGJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk2N4w2LBVPivU0 T/Mi5yHULOa82MsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3ecldG0DFrrx8RYZWc QpsIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbhVq/kQPPqgH2PU0ZUB0tG6ItN5Kk tB2lq6ZewsoLrDhh7FIO/VYO3kW0axuy+aWez7m75zVlgufIk6EL/dGVhhpe9RDpKAnWCcVr pT0KxhUBvyHr/q2wba6UvFhwNsqNs7yIYISoGpI1jLIC/s6B5rOK0nPzYUChW9r15gRdRrYT 5QyShF9YEjkWjFeNX0uEZYw27v2uGaqJlW0r3rQ/8Lb+VP71AF9yr/FKNPRZNGRA8NYgi6wq W7MunzwHhoaOce30j2Y6HmhmebVkGX8Qo16KVGj3qUxxg3KgzVIVlhMDAT9qPWijguyStQZK lcMvCAjqac7/0uuCNPwN/GlnEO5Utcnc4I4O4UHBMulkMI4Py7x6qM4ovKtpTDoWALahdDn6 7NRo+7UOA== IronPort-HdrOrdr: A9a23:eLCR0KGsWmdJHDjapLqE18eALOsnbusQ8zAXPiFKOH5om6mj/K qTdZsguCMc9wxhPk3I9ertBECrewK4yXcN2/h0AV76ZniAhILKFvAA0WKB+Vzd8kTFn4ZgPM FbHJSWY+eRMbEVt6jHCUaDYq8dKaG8gdiVuds= X-IronPort-Anti-Spam-Filtered: true Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([217.136.81.33]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2022 12:08:13 +0200 Message-ID: <88650019deedbf4192af4cf3e2a9acba6828c6b6.camel@skynet.be> Subject: Re: [PATCH 1/7] event_location -> location_spec From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sat, 28 May 2022 12:08:12 +0200 In-Reply-To: <20220527180248.2990723-2-pedro@palves.net> References: <20220527180248.2990723-1-pedro@palves.net> <20220527180248.2990723-2-pedro@palves.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2022 10:08:17 -0000 On Fri, 2022-05-27 at 19:02 +0100, Pedro Alves wrote: > Currently, GDB internally uses the term "location" for both the > location specification the user input (linespec, explicit location, or > an address location), and for actual resolved locations, like the > breakpoint locations, or the result of decoding a location spec to > SaLs. This is expecially confusing in the breakpoints module, as > struct breakpoint has these two fields: FWIW, I think that the introduction of location spec in the manual and in the code is a nice improvement/clarification. Thanks for Pedro and Eli hard work on this. A small question: In GDB, when I do (gdb) apropos -v location possibly some occurrences of "location" might be changed by "locspec" or "location specification". (e.g. in 'help breakpoint/break-range/disassemble/strace/...' and I have not seen that the patches are modifying this online help. Also, is the constant #define LOCATION_HELP_STRING not better called LOCATION_SPEC_HELP_STRING ? Thanks Philippe