From: Bruno Larsen <blarsen@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 01/11] gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp
Date: Thu, 27 Oct 2022 10:37:02 +0200 [thread overview]
Message-ID: <886c6c34-ff72-5c47-6e65-4722295384cc@redhat.com> (raw)
In-Reply-To: <87h6zq7pyf.fsf@redhat.com>
On 26/10/2022 14:02, Andrew Burgess wrote:
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> When attempting to test gdb.cp/class2.exp using clang, it fails to
>> prepare with the following error:
>>
>> Executing on host: clang++ -fdiagnostics-color=never -Wno-unknown-warning-option -c -g -o /home/blarsen/Documents/fsf_build/gdb/testsuite/outputs/gdb.cp/class2/class20.o /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc (timeout = 300)
>> builtin_spawn -ignore SIGHUP clang++ -fdiagnostics-color=never -Wno-unknown-warning-option -c -g -o /home/blarsen/Documents/fsf_build/gdb/testsuite/outputs/gdb.cp/class2/class20.o /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc
>> /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:53:14: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
>> typedef class {
>> ^
>> Dbase
>> /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:54:2: note: type is not C-compatible due to this member declaration
>> public:
>> ^~~~~~~
>> /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:58:3: note: type is given name 'Dbase' for linkage purposes by this typedef declaration
>> } Dbase;
>> ^
>> 1 warning generated.
>> gdb compile failed, /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:53:14: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
>> typedef class {
>> ^
>> Dbase
>> /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:54:2: note: type is not C-compatible due to this member declaration
>> public:
>> ^~~~~~~
>> /home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.cp/class2.cc:58:3: note: type is given name 'Dbase' for linkage purposes by this typedef declaration
>> } Dbase;
>> ^
>> 1 warning generated.
>> UNTESTED: gdb.cp/class2.exp: failed to prepare
>>
>> This can be silenced by adding -Wno-non-c-typedef-for-linkage. The test
>> shows no failures with this change.
>> ---
>> gdb/testsuite/gdb.cp/class2.exp | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/class2.exp
>> index 32f9dfc18a5..e1e4ad0fae6 100644
>> --- a/gdb/testsuite/gdb.cp/class2.exp
>> +++ b/gdb/testsuite/gdb.cp/class2.exp
>> @@ -18,7 +18,7 @@ if { [skip_cplus_tests] } { return }
>>
>> standard_testfile .cc
>>
>> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
>> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++ additional_flags=-Wno-non-c-typedef-for-linkage}]} {
>> return -1
> I worry about just adding an extra flag like this. GCC is happy enough
> as it ignores unknown arguments, but some other compiler might be
> unhappy.
>
> Additionally, with earlier versions of clang++ (I tested 9.0.1) the new
> flag isn't recognised, and actually causes the build to fail.
Good call. This flag seems to have been added by clang-11, so I'll check
for that version.
>
> I wonder if we should look to something like gdb.cp/pr9167.exp for how
> to solve this? In that script we do this:
>
> set flags [list debug c++]
> if { [test_compiler_info gcc-*] && [gcc_major_version] >= 10 } {
> # Work around PR gcc/101452.
> lappend flags additional_flags=-fno-eliminate-unused-debug-types
> }
>
> this might be a better model for how to add the flag.
Looking at gcc_major_version, this looks too verbose. gcc_major_version
already checks for the given compiler, returning -1 if the compiler is
not the expected one, so that code from gdb.cp/pr9167.exp could be
shortened to:
if { [ gcc_major_version ] >= 10 } {
....
}
What do you think?
(I also think the function should be renamed, but that is a patch for
another day).
Cheers,
Bruno
>
> Thanks,
> Andrew
>
next prev parent reply other threads:[~2022-10-27 8:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 17:07 [PATCH 00/11] Cleanup gdb.cp tests when running with clang Bruno Larsen
2022-10-04 17:07 ` [PATCH 01/11] gdb/testsuite: ignore Non-C-typedefs for gdb.cp/class2.exp Bruno Larsen
2022-10-26 12:02 ` Andrew Burgess
2022-10-27 8:37 ` Bruno Larsen [this message]
2022-10-28 11:37 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 02/11] gdb/testsuite: enable running gdb.cp/classes.exp with clang Bruno Larsen
2022-10-26 12:19 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 03/11] gdb/testsuite: account for clang's recursive destructor calls on gdb.cp/mb-ctor.exp Bruno Larsen
2022-10-26 12:35 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 4/9] gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using clang Bruno Larsen
2022-10-04 17:09 ` Bruno Larsen
2022-10-04 17:07 ` [PATCH 04/11] " Bruno Larsen
2022-10-26 12:37 ` Andrew Burgess
2022-10-26 14:50 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 05/11] gdb/testsuite: allow for clang style destructors on gdb.cp/m-static.exp Bruno Larsen
2022-10-26 13:04 ` Andrew Burgess
2022-10-26 14:51 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 06/11] gdb/testsuite: add XFAIL to gdb.cp/ptype-flags.exp when using clang Bruno Larsen
2022-10-26 14:08 ` Andrew Burgess
2022-10-27 13:17 ` Bruno Larsen
2022-10-28 11:38 ` Andrew Burgess
2022-10-31 12:45 ` Bruno Larsen
2022-10-04 17:07 ` [PATCH 07/11] gdb/testsuite: skip gdb.cp/anon-struct.exp " Bruno Larsen
2022-10-26 14:49 ` Andrew Burgess
2022-10-27 13:46 ` Bruno Larsen
2022-10-04 17:07 ` [PATCH 08/11] gdb/testsuite: disable gdb.cp/typeid.exp " Bruno Larsen
2022-10-26 15:37 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 09/11] gdb/testsuite: fix gdb.cp/converts.exp to run with clang Bruno Larsen
2022-10-26 15:54 ` Andrew Burgess
2022-10-31 12:46 ` Bruno Larsen
2022-10-04 17:07 ` [PATCH 10/11] gdb/testsuite: remove XFAIL on gdb.cp/temargs.exp Bruno Larsen
2022-10-26 15:57 ` Andrew Burgess
2022-10-04 17:07 ` [PATCH 11/11] gdb/testsuite: disable gdb.cp/call-method-register.exp with clang Bruno Larsen
2022-10-27 9:49 ` Andrew Burgess
2022-10-31 10:51 ` Bruno Larsen
2022-10-18 8:10 ` [PING][PATCH 00/11] Cleanup gdb.cp tests when running " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886c6c34-ff72-5c47-6e65-4722295384cc@redhat.com \
--to=blarsen@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).