From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127411 invoked by alias); 31 Aug 2016 10:25:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127400 invoked by uid 89); 31 Aug 2016 10:25:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 10:25:56 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 559647F342 for ; Wed, 31 Aug 2016 10:25:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7VAPs82002081; Wed, 31 Aug 2016 06:25:54 -0400 Subject: Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume To: Sergio Durigan Junior , GDB Patches References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-2-git-send-email-sergiodj@redhat.com> From: Pedro Alves Message-ID: <88f0aa5b-35de-4382-0a34-2c0df2ca1546@redhat.com> Date: Wed, 31 Aug 2016 10:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472443911-29056-2-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00305.txt.bz2 On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote: > diff --git a/gdb/target/target.h b/gdb/target/target.h > index 76af732..1bfa1b0 100644 > --- a/gdb/target/target.h > +++ b/gdb/target/target.h > @@ -70,4 +70,10 @@ extern void target_stop_and_wait (ptid_t ptid); > > extern void target_continue_no_signal (ptid_t ptid); > > +/* Restart a target previously stopped by target_stop_and_wait. Given you're using this function in other contexts, this sentence doesn't sound right. Likewise, the existing comment on top of target_continue_no_signal is no longer accurate. Otherwise LGTM. > + SIGNAL is delivered to the target. This function must be provided > + by the client. */ > + > +extern void target_continue (ptid_t ptid, enum gdb_signal signal); > + > #endif /* TARGET_COMMON_H */ > Thanks, Pedro Alves