From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2077.outbound.protection.outlook.com [40.107.92.77]) by sourceware.org (Postfix) with ESMTPS id C813838582AC for ; Fri, 11 Nov 2022 13:58:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C813838582AC Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dFtWKAu5bDYoe5C0H4owEVjdxX8JiK8Cz7mm+oZtKVvDbEn5WKr942g+3f2GODtV5aLdWYsAcQfLYvYQiWq51olNE04pli5Y8yqiq/cDHvlqXYlghcUd52HHnboIEGGFYGM7flGNMxjwyz6n4tnqeVHG8rgx9mDODTwzRpa5kA1WBpkcOT9v74chTEE4U/uukrJwa/FU9/DO12naWJaOf5WgNLO6kthx34VpUwzeKTytq8AJl3Q2YxV+J1SbWa9AYOlAMy+6eihCmFEvjg3csn1lKIZKQEOTJ3Nh/hUxKOl6GO/C3CiPO9GCSTZFfO2VSKe5HEYHsc/1wTBPDW9vZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QGETU+QFt1RI3mNHum2aKw7DcElsnaYgIOn0IIeF4HY=; b=hq0i/xwsipn9WGBh7C6kVOgTzfrhBD12iBx4AMQ6sU7HVTkr8YZyPj2bhRSIdNP7Niuacaj9isbLWLBye8eqytaq1/AcrfJOLw1CFiEnHekANc5Zgn8XrcgRRyeCV64z9j15P68hJzid+Ok8uPtMlZD2rhzZiM5PE9RXihhGdjfttHk+/05bX1nDYhUyWfTgDOmMULq6GybIHuoCRjg2nO6ww0p4e0qVC57pD0zEWBtQbE8kWTADliZDcyuPMZZkxL+fIIjP25MZz0mtxa5aylvdTpIHOWkseFAcees+FDPXeVMEElwlYB1wcHoixbsm/RKKFPZdYT34ZCGhfbs/Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QGETU+QFt1RI3mNHum2aKw7DcElsnaYgIOn0IIeF4HY=; b=ae44XetFpnn9K1QPY4ZCnJDjpNF8XwTNh7GdfjiXlseamLiauta8xmsrVvxlhOdM0Qg59I4FYERQBM+dJ3cISJTz+T88APnwyFlhyMVcyDvNtKXyh/b2m/UJqe6vcmNKaRc7V4ZV06wiEd5XDHz2abH2jQ2GuK9idpXLx72w3jo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by SA1PR12MB7151.namprd12.prod.outlook.com (2603:10b6:806:2b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Fri, 11 Nov 2022 13:58:50 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::15e7:2ef7:ccc0:7f52%6]) with mapi id 15.20.5791.024; Fri, 11 Nov 2022 13:58:50 +0000 Message-ID: <89166a4e-40d3-df09-0c2e-7c5dcfa0d54d@amd.com> Date: Fri, 11 Nov 2022 13:58:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] gdb/py-inferior: Keep inferior threads in a map To: Tom Tromey , Lancelot SIX via Gdb-patches Cc: lsix@lancelotsix.com, simark@simark.ca References: <20221109185120.1828613-1-lancelot.six@amd.com> <87mt8yy8c4.fsf@tromey.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <87mt8yy8c4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::9) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|SA1PR12MB7151:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ecf8bb7-998f-48c7-066c-08dac3ecdc00 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M5GKrr0iGlnL/Q0tEtv93+0hrh8x8BsUfUDrZ2LgFdPJvIvTnrwpVAkzvGMN4AtNpkc53CXqfwQOHt5XLLJZUrJ/4qZijFjemfqS3x8lAUVLCV9d+pVfS+9QtRhDhvGa/cr+ZhlM32tgRAduUhaW43IJylF25k8N6OVaV7CIz1MKWQJLElrv7i+fdPAPIx8OnTbI6flVSQBZmc1zdvJcwLiBLMsDQAbNVaU2GT4sAhygC6VvzKRUcu6nV6k4q7hj5JQNkWGYtMWsMuh215rgYdK69s5j3O37vieiOvoBKBy41bKEqLei3A6f95RlKcWF/NwIjkUpaiHmu+UHRDgHr9jsiUUi9cBhnG6j+GRknhmvL4sdZKNg3Lo5T9k5mA5BkgfhE4OYkdjW8wMbLImcaZeHoNWQCSuOonlWHGVODPfYu+PSYzNLaqjHEXkzkbCUuyVeTgouhSlQ/BxKs0lf41tDd+6aP0gXwNPZ+CtRy+Zeinxx0GMbbivxXhUsyoMgDhT4NXbwBepdYp2p0t7XYLmfXUqQoRFHQyVGRjSZcuxKGZz0KguBXYn1ETh9fVGoIea/PHjCb4txGOc0HjGw58mjsUY09LkdeSfewNAm7JIrF7D2p9pinOAGGzwjxcQfSnZW+K+bY5b8kggyIE5d7uQtQD+XKlB+A/t5CV1XetPwYFY7ME3FbaJ668YOBfwDj1aJe/vAfq0HdqcpMGG6I40fDHHT+DJ/6Xzl/NJOf2RtiStHVwLsfyUclxcP/SXmxdNb5IV5F4lIs7bWX+YwNAYZ5gJrxrlcMMpcWyDlBJQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199015)(2616005)(36756003)(6666004)(31696002)(4744005)(186003)(5660300002)(6506007)(41300700001)(4326008)(8676002)(110136005)(83380400001)(66946007)(2906002)(6512007)(31686004)(316002)(8936002)(86362001)(66476007)(38100700002)(478600001)(6486002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czdFTUw1dWhVekNQb0IxY0dxaHZIUmkyMHloUVh1cUxJdE1xRHdTREZhTEFz?= =?utf-8?B?eXllWk00Qm91K0d4SkY0QzUydWw0WXBHTGcxMG1CKzJxZjNKK2MrNUxCWlJk?= =?utf-8?B?RXBjQVMyVXBBTDdxSzBPbkt6eVI4ZlpJQTR2Y29GREl2OXJNelhLbWpIWmU0?= =?utf-8?B?U0ZrZGdPNDQ5MWk0c1dBVEFPSnBWUkRoeGNqZ0hKQ0ZTNHl5RTRyOGdWd2dK?= =?utf-8?B?MTVBQkxHaFo5UjViTVZ6bTg5T21UQ09QNlNLaUF4Uks3Q2U3cDNKc1BmSGYr?= =?utf-8?B?Z1BSTDBJL29BQ1FvZWVPcXhmMHR2dnk3WG9GeWNCUzM4WThjMTFlc3FkeXVI?= =?utf-8?B?NlBCU3RwQUlYbmVtREtQeDQ4dDRlL3Q2OUFHL2h1NytGQTJPamtuenlLVEh1?= =?utf-8?B?SkJpYmhjcVVHVWtLYUw1OVQxczhHNkNidVVTRUJRSHg5N0R1MzBjSi9kaXhw?= =?utf-8?B?cUxjM0ZwdkQ2aHlQVmxManZGWS9YaHFxYW1hYjl6RTVXTC8xc2R4RkJieEow?= =?utf-8?B?Q0NueHp1Wm9BazRZMTlYclJuemVHcVhvTmtCY3Z0dXgyODJzVTRLckF0aFRB?= =?utf-8?B?TTJNa1JNYVlHNFNGcFVIZ1dzOVNIalAwamg0QXJYcXE4N1YyRE43bVBIcHlr?= =?utf-8?B?NUdIUFNLWTkxQkFCVzNtc0JnMG4rZUU3dWZHSEgzVTI5NWxlWG5McGNLY3hp?= =?utf-8?B?ZWFlQjNaVWJJWkdZNGJxR294WU9ZKzluZ1lyU1I3aGV1NlR2cGQ1Q2lSNXBN?= =?utf-8?B?R3JFS0dwZ0VwL21adGZYekFzUUN0dWNmbkp2dW0xUG1aWWFWbjdacTJIdjdr?= =?utf-8?B?VmtxVVZjWUh1N0tBZmFsNVNGMDd1a3B2bFEyTjdqVVl1N21yNWI1SGI5M2Qy?= =?utf-8?B?QUtQQnBoeUUvT0NkZ3FkLzlxT25PbTFPaWRORzFpc3BzeG92OEhZYU1xV1Ba?= =?utf-8?B?RWlXelpFRklBVVErOXU4RkV1d0Evdis4djhNamhyTDVKYzRlN0orWFIyL0xL?= =?utf-8?B?OTM4V1hVcnViUDFZM3lzbXpkMjl3ekx0dWpNVEwyaHhzOTk1OXFTK1h5WFk5?= =?utf-8?B?cVJVMjF6a3h0bWl0V3dONkJod1J6dnVVTTI2akU2SHRaeWpnOVlGVEl1d0hS?= =?utf-8?B?d2k3R3lEZVZmMFpUSVd3RmxpV1FMVGxrK05OSjRPSFFtdGZueERlTjhJRUcw?= =?utf-8?B?cVpldGNWSy9mWC9vVGxXcmhiR29SdFJyU1VtRFpvMWMwcUI1RGlFRFRPTkhF?= =?utf-8?B?dmxxZGEvY2RST2VOTTMzcTBjK01jUHZnSnYrVDBrTGtnWTllc3hBdXdMemVX?= =?utf-8?B?WVhuTGFTbURLbm9sdE1ZTUNOcjFiWXhuc1puUmMzcE9YMkZmUGt5L1B2cmdL?= =?utf-8?B?SWUyRHBVMWVZdGFRRVNjRHAvTlV0SEk0V1llaVFIYlVNL2ViVlNNWHVvM1B1?= =?utf-8?B?aTVyVU11Wkw2MTA3d29SL3cwTVZCNUhSaE9DSDVQQndjU0hRcXZvbVJtZ2dU?= =?utf-8?B?eGpGSm1NWGdlMWtVbDQ3Yk50TXVVbFA0NHNIVTJNRDNMQTA3RWFKYlgrc3Nz?= =?utf-8?B?RGRkWVl6elF5Ym5OeWtvalFzQ2Zya0tnakxvazBTb0s2N0xHUWM5MEk0UU9F?= =?utf-8?B?SUpXeXVrN3pIQjlkUExnVDFQK252eVhVVVJvTkVTNTRXdnA5TzRJbzZBRUQ1?= =?utf-8?B?OGVBRTlrbGlVa2FpYjFMZGdDME8vMjBudVhDbkluSnBCSktMQ3pFczhPQi9z?= =?utf-8?B?SG5hVXM1UmpJY2pzRlhtNURQSGMyU1NjcUQzamE0T1Z3UXJHVUVYenN6MXB5?= =?utf-8?B?Uy9NdzNtTkdjRWliNzJkQnIzdzN1QVpac1h3RTJaeHZJSlJ3L3Y1cnc4aVNx?= =?utf-8?B?QmhnRGFzUTNGVFRkcjJLQU1KR2NLczYySXlGVjEybExQMkhsSlNmdVlmZWtv?= =?utf-8?B?c3pnMjlPMzJXdi9FK2RrMmhGem0wVHYyUUxYSyt4MDFIbE1tL3Y1aWMwYldM?= =?utf-8?B?alRpTWNVMFZOMlRHOU1FRzFCYU1EdXU4VlozY0x6TldRU3hJeXRWNFJYMHVp?= =?utf-8?B?bTFFOVA4SUpOSzFTTjJWclpBL0RGZWVqK3lPSjhKaTdNQzRXSStKWE1udFUz?= =?utf-8?B?d1VrMFd3RUNBcHZzUnBhRUhnSGdnZTROZncyTXM2WnFJVWUrR2IraVNuUzQ2?= =?utf-8?Q?1p1l26DbiHy73tX4W6X3820=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ecf8bb7-998f-48c7-066c-08dac3ecdc00 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 13:58:50.0626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J3ylt0v2zTOW1BKxNbRqUXR6J1SaSeIr+ISA0CE0caPXur11EClC89SrxTw5PdwnPoIeVv68FKz3Dx9/h8UoOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7151 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>> Changes since V1: >>> - Changed the implementation (and description) to use std::unordered_map >>> instead of std::map. >>> - Added a comment in delete_thread_object to explain why we do >>> "it->second->thread = nullptr" as this is easy to miss. >>> - In infpy_threads: move i's increment outside of PyTuple_SET_ITEM to >>> avoid issues if this is or becomes a macro evaluating its arguments >>> more than once. > > Thanks, this is ok. > > Tom Thanks. I just pushed this patch. Best, Lancelot.