From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id 3BA633858C27 for ; Tue, 28 Feb 2023 11:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BA633858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677583824; x=1709119824; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ewV8UAvdV27OySm/CjK5EllppsVgyxAjrPgpMfWH2o8=; b=LxpX0jbafeqLgBT+gHEHqVIpln9zabfnv/IptxI4VK3wlPYXp5+MntEw OtkhThY/9qD5ArDuwCzbyNCGjR5vVXNBFpShVGIYjE90oNIoNdPX0U+zM PI4rPEFNS7YtlpQEp8y621cLoNajSIX8JceHLkl+gARJ3RkArrPash7yj 1dxWcu5EWy09zHE8mqgDlEJ87FqS3Xm92t0m/o9E8zTvPkXcwyG33sHpb G9n2ECZm20QRR7Nvxv0anQKHbXeCle/5lRTtg886j2aKr3bC2GorPIIEI aPyOrD9Oy+/qbZj3APVO38tFQW9Sttqt4a8VFGE5sPSUYqDsB+MOwHTYb Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="420374093" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="420374093" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:19 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="848213584" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="848213584" Received: from ultl2604.iul.intel.com (HELO localhost) ([172.28.48.47]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:30:18 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH 15/26] gdbserver: check for nullptr condition in regcache::get_register_status Date: Tue, 28 Feb 2023 12:28:13 +0100 Message-Id: <893ba2a52032456c31cbb868c2f2ae4e0661b6e0.1677582745.git.tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: A regcache can be initialized with a register value buffer, in which case, the register_status pointer is null. This condition is checked in set_register_status, but not in get_register_status. Do this check for consistence and safety. --- gdbserver/regcache.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index ec11082be6f..0c6f1eb392b 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -489,7 +489,10 @@ regcache::get_register_status (int regnum) const { #ifndef IN_PROCESS_AGENT gdb_assert (regnum >= 0 && regnum < tdesc->reg_defs.size ()); - return (enum register_status) (register_status[regnum]); + if (register_status != nullptr) + return (enum register_status) (register_status[regnum]); + else + return REG_VALID; #else return REG_VALID; #endif -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928