From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 005073858D20 for ; Tue, 8 Nov 2022 09:55:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 005073858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667901324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RNh19q2vX2zbU+C1/w4XXcFm/P3FUCBFFjoxjvJm4XA=; b=NndrGPU2UfHP1EndbHHrUdoKpD+IY4Bjy55egcz2uHPP6eWEB0XR6UiAtz4C0SeDQ9EoGu Bna9G4Y+2hDiUq7srPM9pdytibudedYVJ+7S1b/h3KWwUl1Xv0Laqh4mkcgRztPdWzouLL wJXgU12j55Hlkcx1JTVBHEAv9FV/fqw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-620-4YALjVpuO0OJPjNG6zQj0g-1; Tue, 08 Nov 2022 04:55:23 -0500 X-MC-Unique: 4YALjVpuO0OJPjNG6zQj0g-1 Received: by mail-ej1-f72.google.com with SMTP id hs34-20020a1709073ea200b007ad86f91d39so8094917ejc.10 for ; Tue, 08 Nov 2022 01:55:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RNh19q2vX2zbU+C1/w4XXcFm/P3FUCBFFjoxjvJm4XA=; b=FyyWIhSXbkDdtcgQpiMoBenb3QihgRnAEaT5QTuUibwTgTdpr0JwNE42tXxkcqE9V0 /Sb/eBQoVcKq7g/LBGpPfQJnSp8TSMVyTknj/wHNHkh55cHiXDid4IGxnJJ0kbFZiO/t gBcJARYwG55l7+Bw/ZpFdI1Mtemf5Nwdk/hGCskfP1omKL0JnQMhsGJhx8h/8XFWWRqp 0VJbBEE2xitMBCTqdZpduH98eufuu3jYHJtpk6GrjS+f2n7KhcyrCaHVb9fMDj7to4hc riFpWJS+4sYBDjpf4/OZEv2k02tEcv8pKNKYA5zmtSUwaED/jJacwU8iZS5JIBuewtIs 55QQ== X-Gm-Message-State: ACrzQf2zAOXsUUJion+YIPe2zwT3BYyUGRkxi9qj2xNPqVQkrdiM1c/d PyTI12T03eSYHtPzNHrPlOa7KwXQ7dUDUwxn2eUufNNKld9i8+dOtORCDjRAOQqoqFncK8ysRLb pi0xOaHeigy9VtAhJrNMQog== X-Received: by 2002:a17:907:d03:b0:7a2:d213:de18 with SMTP id gn3-20020a1709070d0300b007a2d213de18mr53460514ejc.124.1667901322149; Tue, 08 Nov 2022 01:55:22 -0800 (PST) X-Google-Smtp-Source: AMsMyM5gCsh1y/ZGMzWC2AIVZ0geSAh9XCzSxcm51XXPdWHI5N15m645qJ+8TODcak8gsGomXDqsJQ== X-Received: by 2002:a17:907:d03:b0:7a2:d213:de18 with SMTP id gn3-20020a1709070d0300b007a2d213de18mr53460503ejc.124.1667901321993; Tue, 08 Nov 2022 01:55:21 -0800 (PST) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id q2-20020a17090676c200b0073cf6ec3276sm4083453ejn.207.2022.11.08.01.55.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 01:55:21 -0800 (PST) Message-ID: <894cf31a-40dd-b1d4-fd87-e9679e06fec3@redhat.com> Date: Tue, 8 Nov 2022 10:55:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 3/7] gdb: move frame_info_ptr method implementations to frame-info.c To: Simon Marchi , gdb-patches@sourceware.org References: <20221107155310.2590069-1-simon.marchi@polymtl.ca> <20221107155310.2590069-3-simon.marchi@polymtl.ca> From: Bruno Larsen In-Reply-To: <20221107155310.2590069-3-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 07/11/2022 16:53, Simon Marchi via Gdb-patches wrote: > I don't see any particular reason why the implementations of the > frame_info_ptr object are in the header file. It only seems to add some > complexity. Since we can't include frame.h in frame-info.h, we have to > add declarations of functions defined in frame.c, in frame-info.h. By > moving the implementations to a new frame-info.c, we can avoid that. My guess is that Tom was prototyping the solution like this, and I caught it and sent it before finishing his train of thoughts. (That or I wasn't sure of how to add a new .c file, always a possibility...) This patch makes sense and generates no build issues or regressions on my system, so: Reviewed-By: Bruno Larsen -- Cheers, Bruno