From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 941283858D33 for ; Mon, 23 Jan 2023 20:08:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 941283858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id o17-20020a05600c511100b003db021ef437so9450197wms.4 for ; Mon, 23 Jan 2023 12:08:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jX/4orMvBnnZB5q13o1IYg8nn+ZirCppxQoPu0zw/Ts=; b=gNjcYtz50toMpVrwj1dvMGp/s5raaVHf7qir1YtSQhkaz7+Yf91mffBpr5izVOoU7z XqKpaCkykAqJ0Zdt+95Fb76YWPC1vrla4nP63goUzCLfgTsYeIgRXd8BjTAL6z2IyANg b6AatoGYuK7UCJN+bPK2+Qvr4BX7jqZFOBskef2iEwjZE1cvVFx+EYi8pot+obH2Bm2v c1GCB0Zji1Fy2Bh1V1Pp8nyaTkbjiXBNEzDglm7haqUfFd53XlFOdghvn7Qr1pDZJnC6 hPqKkSBOEsrHtil59GAdkd+YERt3j8eyMUmg3XoKLUnWsyf8gLFGpt+7y3S9g88iWZFS XqkQ== X-Gm-Message-State: AFqh2krEsUxpohz62tnkVSKaJWicqRZZz5tZ9rH5ukEzKBxiBlwVZO6B hPxNCyuChb9aFwIhcLVI/Znd7hC7ZSeokg== X-Google-Smtp-Source: AMrXdXuWZzcIfUlBEmwHCnpXY0BdV7iqp5QASw+kuU3OHhSiJ6ZEFNzCI0ohyx2JAZq9MIzB8Fu1aw== X-Received: by 2002:a05:600c:31a3:b0:3da:6a6:739d with SMTP id s35-20020a05600c31a300b003da06a6739dmr25477455wmp.19.1674504525403; Mon, 23 Jan 2023 12:08:45 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id c10-20020a05600c170a00b003db15b1fb3csm127434wmn.13.2023.01.23.12.08.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 12:08:45 -0800 (PST) Subject: Re: [PATCH 8/8] Use require with is_remote To: Tom Tromey , gdb-patches@sourceware.org References: <20230122215558.1931803-1-tom@tromey.com> <20230122215558.1931803-9-tom@tromey.com> From: Pedro Alves Message-ID: <89500e1e-647b-bda9-70b5-8883b5367fb8@palves.net> Date: Mon, 23 Jan 2023 20:08:43 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230122215558.1931803-9-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-22 9:55 p.m., Tom Tromey wrote: > --- a/gdb/testsuite/gdb.base/fullpath-expand.exp > +++ b/gdb/testsuite/gdb.base/fullpath-expand.exp > @@ -15,10 +15,7 @@ > > standard_testfile .c fullpath-expand-func.c > > -if [is_remote host] { > - unsupported "compiling on a remote host does not support a filename with directory." > - return 0 > -} > +require {!is_remote host} IWBN to preserve "compiling on a remote host does not support a filename with directory." as a comment. > --- a/gdb/testsuite/gdb.base/gdbhistsize-history.exp > +++ b/gdb/testsuite/gdb.base/gdbhistsize-history.exp > @@ -21,10 +21,7 @@ > # We cannot expect remote hosts to see environment variables set on the > # local machine. > > -if { [is_remote host] } { > - unsupported "can't set environment variables on remote host" > - return -1 > -} > +require {!is_remote host} Similarly here. > diff --git a/gdb/testsuite/gdb.base/solib-corrupted.exp b/gdb/testsuite/gdb.base/solib-corrupted.exp > index 644c8ece11f..a2fbaa6ac40 100644 > --- a/gdb/testsuite/gdb.base/solib-corrupted.exp > +++ b/gdb/testsuite/gdb.base/solib-corrupted.exp > @@ -15,11 +15,7 @@ > > require allow_shlib_tests > > -if {[is_remote target]} { > - # gdbserver prints the warning message but expect is parsing only the GDB > - # output, not the gdbserver output. > - return 0 > -} > +require {!is_remote target} Ditto, comment should be preserved, IMO. There are a few more, I've not pointed at every one. Basically, these help us understand what particular issue with is_remote boards causes the test to be skipped. The cases where the messages were just "doesn't work on remote host" such as: > -if {[is_remote host]} { > - untested "does not work on remote host" > - return 0 > -} > +require {!is_remote host} are useless and should not be preserved of course.