From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 213D53858D20 for ; Sun, 26 Nov 2023 07:55:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 213D53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 213D53858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700985314; cv=none; b=X+sV+iaB2tjBbcITxY7VYgLXol8l3hncLjru9iJ+cqobV8lW0CK0ZZM1RWiu5jVqScWG68e7sU79t6CJD39Ko2Pv3xMRU3TR5qdTXEqN/YHo0K/ulFOoQnoj4ror42cezLgrN+vVJiA49hPPLSP3k8WDtILmW2e3wtUNqHfDTTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700985314; c=relaxed/simple; bh=kagl7dGKxOC8fxAX++buowCkJ7Mgb9TegDXOgOlviCc=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=fXYiZpgvOCtEy5cIGD5h8500cpTt2O2EHN5ne4E91tqsbydAbnZIAUh2NseAMDaE6YTa21MNz+3ktNyrU1rqxJHG7mYOe5SU3O3nVDeRGl4lMQXJ7tzHaAn14MiNTd5ro+sjwbt+TUPfZ7/fUZLr4Np/xJDilVH0c49OAtKfU8Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1BADB1FB6D; Sun, 26 Nov 2023 07:55:12 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C2D3613488; Sun, 26 Nov 2023 07:55:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id f4tvLN/5YmVLZgAAD6G6ig (envelope-from ); Sun, 26 Nov 2023 07:55:11 +0000 Message-ID: <895796fd-4e70-480d-8d7b-2d2493805ba9@suse.de> Date: Sun, 26 Nov 2023 08:55:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Show regs when switching to regs layout Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20231124102710.7681-1-tdevries@suse.de> Cc: Tom Tromey In-Reply-To: <20231124102710.7681-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ++++++++++++++++++ X-Spam-Score: 18.40 X-Rspamd-Server: rspamd1 X-Rspamd-Queue-Id: 1BADB1FB6D Authentication-Results: smtp-out2.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Spamd-Result: default: False [18.40 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(3.00)[1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; BAYES_SPAM(5.10)[100.00%]; R_SPF_SOFTFAIL(4.60)[~all:c]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(3.50)[1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/24/23 11:27, Tom de Vries wrote: > When starting gdb in CLI mode, running to main and switching into the TUI regs > layout: > ... > $ gdb -q a.out -ex start -ex "layout regs" > ... > we get: > ... > +---------------------------------+ > | | > | [ Register Values Unavailable ] | > | | > +---------------------------------+ > ... > > Fix this by updating the TUI_DATA_WIN in tui_apply_current_layout. > I've submitted a v2 ( https://sourceware.org/pipermail/gdb-patches/2023-November/204507.html ) that handles this in rerender instead. Thanks, - Tom > Tested on x86_64-linux. > > PR tui/28600 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28600 > --- > gdb/testsuite/gdb.tui/regs.exp | 10 ++++++---- > gdb/tui/tui-layout.c | 6 ++++++ > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/gdb.tui/regs.exp b/gdb/testsuite/gdb.tui/regs.exp > index 520f6ddba96..0be99625b9f 100644 > --- a/gdb/testsuite/gdb.tui/regs.exp > +++ b/gdb/testsuite/gdb.tui/regs.exp > @@ -41,10 +41,12 @@ Term::command "layout regs" > Term::check_box "register box" 0 0 80 8 > Term::check_box "source box in regs layout" 0 7 80 8 > > -set text [Term::get_line 1] > -# Just check for any register window content at all. > -Term::check_contents "any register contents" "\\|.*\[^ \].*\\|" > - > +# The current frame is main, check that registers are available. > +set re_reg_vals_unavailable \ > + [string_to_regexp {[ Register Values Unavailable ]}] > +gdb_assert \ > + { ![Term::check_region_contents_p 0 0 80 8 $re_reg_vals_unavailable] } \ > + "Register values available" > > # Check that we can successfully cause the register window to appear > # using the 'tui reg next' and 'tui reg prev' commands. > diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c > index 85f4991c769..813f8f93b57 100644 > --- a/gdb/tui/tui-layout.c > +++ b/gdb/tui/tui-layout.c > @@ -112,6 +112,12 @@ tui_apply_current_layout (bool preserve_cmd_win_size_p) > if (gdbarch == nullptr && TUI_DISASM_WIN != nullptr) > tui_get_begin_asm_address (&gdbarch, &addr); > tui_update_source_windows_with_addr (gdbarch, addr); > + > + if (TUI_DATA_WIN != nullptr && has_stack_frames ()) > + { > + frame_info_ptr fi = get_selected_frame (NULL); > + TUI_DATA_WIN->check_register_values (fi); > + } > } > > /* See tui-layout. */ > > base-commit: 2ec31e54dff83130fbde8d2f674469078ee203d5