From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2FF98385740B for ; Sat, 29 May 2021 01:35:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2FF98385740B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14T1YwXi014606 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 21:35:03 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14T1YwXi014606 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 467211E813; Fri, 28 May 2021 21:34:58 -0400 (EDT) Subject: Re: [PATCH 2/2] Fix InlinedFrameDecorator example To: Hannes Domani , gdb-patches@sourceware.org References: <20210526171541.769-1-ssbssa@yahoo.de> <20210526171541.769-2-ssbssa@yahoo.de> From: Simon Marchi Message-ID: <896618fc-de44-3405-204c-f02e4f9d1ab7@polymtl.ca> Date: Fri, 28 May 2021 21:34:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526171541.769-2-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 29 May 2021 01:34:58 +0000 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 May 2021 01:35:05 -0000 On 2021-05-26 1:15 p.m., Hannes Domani via Gdb-patches wrote: > Argument fobj was only available in the constructor. > > gdb/doc/ChangeLog: > > 2021-05-26 Hannes Domani > > * python.texi (Writing a Frame Filter): Fix example. > --- > gdb/doc/python.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > index 4137e8ed796..0d8f480e472 100644 > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -2373,7 +2373,7 @@ class InlinedFrameDecorator(FrameDecorator): > super(InlinedFrameDecorator, self).__init__(fobj) > > def function(self): > - frame = fobj.inferior_frame() > + frame = self.inferior_frame() > name = str(frame.name()) > > if frame.type() == gdb.INLINE_FRAME: > LGTM, thanks. Simon