From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2056.outbound.protection.outlook.com [40.107.237.56]) by sourceware.org (Postfix) with ESMTPS id AB5B13857404 for ; Mon, 21 Mar 2022 21:01:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB5B13857404 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjZQ2tUWOR1UB3yWdugSfHCCY0Bhyn3kd2uw4TldNghDNL5jAR9DUG2DCg2o5jbmxYoshxcc0I0Fn+bhXHiLlmkgQZd4+jc/ATPJwU5FaOh4jiZ/0A2aVTyG5Xx17unuebugvZATgM7JR0H4eNX9nl9DDExYH69Vk3t3S1fKziyxo7DXlML3nEE72ogTn2rSdhLS24R9aBuZxet+yY1QeRI7vGVPcUfpAHBZNzmji5/4AiY632bRpYeA4VOTqKY6ElLBEMYBOIbaYnv+JuJ86iG9oHlD0XEw57P+FQZ2N4e7zKzgYs0kwBHG+qOi5CwrLYFLx5iqea6d+TcXeenZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7eEoaKTUum8+MzmRR4HuD5mo1Z24deOQVFcnjUrCn/c=; b=E0AmQZ+yHKEQzxl/3DH210CnA/tBdFDms2SH+iAvB01omaTXR7rpyk/m8mFO95/ozJZXIzALLJ7BK7m+igf/Gmqey0x+F55fgh0uxEvJNpB4MaWcm9SQNI3LdH2S0CE++wCuAwRMD8RNKXIZEqIvVYGUlabNBskgrZXe+NvUbiql//LuGwm0xG2osG4L/QZipW0plnGayXPVMSzXjkVESUOQYM+16EPIgGpDHLCpV7AyHO+fX04XMM4VTSQoNkJbP8ZfwgqXJ4Vn/nn96BMTNEUEdL/cdWajO122k/3/BRhnXfdbBHRMni4v6j0PFbLQhefs3jKKjOVEdXgJrrtGpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by DM6PR17MB4232.namprd17.prod.outlook.com (2603:10b6:5:2b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.23; Mon, 21 Mar 2022 21:01:55 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::b4e5:7f52:3fb8:ef7b%7]) with mapi id 15.20.5081.023; Mon, 21 Mar 2022 21:01:55 +0000 Message-ID: <897bd508133687e4d30994deecdd87786d71334d.camel@labware.com> Subject: Re: [pushed] gdb/mi: consistently notify user when GDB/MI client uses -thread-select From: Jan Vrany To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess Date: Mon, 21 Mar 2022 21:01:50 +0000 In-Reply-To: <78570a7f-f6c0-5e1b-4178-c9ce401feab7@simark.ca> References: <20220316150914.1254897-1-jan.vrany@labware.com> <78570a7f-f6c0-5e1b-4178-c9ce401feab7@simark.ca> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.43.3-1+b1 X-ClientProxiedBy: LO4P123CA0025.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::12) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e16c5ec-904d-4ad8-3ea3-08da0b7e07d4 X-MS-TrafficTypeDiagnostic: DM6PR17MB4232:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XdG7nOnOXfqICm7lC8ewefegH6/OqqJ4gBolPibFMjqVbg3TF0ruxbib3GF4EPEcH+PqPagIKeyDT4Nc8xH8IOSUexE+s3tEJtKO2vFS+9J9CnJEk2Po0HgTDPRKYd1jKeQU54t5X5RUcOMNKMShTRFN9nUMbdDMj3tUJMq6iIJgMfHS72jtHwMZOtMQ7RfkeHzLDsA0MzqZD1pVu0IP8GI5JEtXIZEwFQplcxgkjI7MSejfCMoXeblalXNCJqaxK93L+Abx57luvUs/Zb1zg5Xfk/PdwG6k4lVhdeb98NIwkjtDdxSEeigKMXrtZs0sra9Z8BM2dSu42amajk50aK7OPHDQIVJE5DCB7Iz6wMld8R2xtwqcV26RKGZUlod3q9O3BxqP5/gPfA73RFhD3wFwzmlh3RTq6xZpGHmgSJjGRiN2+OpEg0MllGfHgD9lwhjrpC5ATyMGyoMmF18+c6Arix1nNKh4RWVNm4kkTSubA9IK7qTUtwzRkBX7gRAz1CAFiGsCeY+dTo4tbCYWR+mM36Tb1GCiPRwEZPO1Y7m8PHVOpXYqQ5pb87mGmXzkta/qfcThaEnCDdMjsTjNqjX1Ow7hcz4abr+Eixr78mIK/IvBdSOwQXNBrvAeD6LTpDvqjBGAL6Sxrbd1mYrnXfOIYWckOyCmOA3urscx1we4KO29uNcjJhPUS59FGimd+wNBZoLoDt1GQa729XCOtn3Ks+SqU91pzfOALCjVv8sHHFLvoUammdSMVPTWVWUlIJLoz37fJDsvm0MQpL2u4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(2616005)(83380400001)(6486002)(966005)(38100700002)(316002)(2906002)(6512007)(66946007)(508600001)(84970400001)(44832011)(8936002)(6506007)(6666004)(5660300002)(53546011)(66476007)(66556008)(8676002)(4326008)(186003)(52116002)(86362001)(403724002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGRFeXptcFJremFlNStLU281VlRQalBmWm9kR1BlZU5wZ2pzaWVOeU5ZejFF?= =?utf-8?B?YlcyUHdOc2QzRnRhYUZhM1J3NVhLYzJtKzdxaWtZNU4xSCtpNE8rSVRvTHlx?= =?utf-8?B?OE5OUkYwM0hTcGZVc2R1YXQvYlBRbFBDdzNPRWFoVEx5aUkyaE81c1pOMlBn?= =?utf-8?B?aHZlOVEweDFRRTg3TE1lL25JNll3YzF2OCt6TnR0RVVFMTdhT1lwRHEzQXhh?= =?utf-8?B?TmtkVmFHVUg4VEV6czZmcjA3S3NxVjF2bWlWamo4cmd5RWh0MkxkNGVPRXhQ?= =?utf-8?B?RlBDLzA5STFZUkl3TXRFMTliZjhLc2VuMkJGb0ExRCsyK1NPU204UUE4RFZk?= =?utf-8?B?T2dzRjRjaVB3MjhBUzlsZ2toR2NhVmZnRXR0c2NydWpBckJWVit2MGdOVGhh?= =?utf-8?B?TWRjYnJPWldsZ3gxbVJ4RER2Z1VRakpER3pkNWI1STJ2emhmYkY3U1kzTmJL?= =?utf-8?B?eDY3Rk5yMGhLZUxoUUlycG5iWitHbkxpMnR6MW1pcVpkWUJGOFhiUWh1Y2FJ?= =?utf-8?B?U0RJcGxQdGtJZkszM1Z3REZMVjN3SG9zOHk1alpDM2tYb3o5WFpFc25EVmdp?= =?utf-8?B?ZlJqU2lYbUxBWG1xQi9mOWtXdVZWUXVOcGdNMzF1L3NDRmEwc1RVU3Q2UUds?= =?utf-8?B?emZicTl1Y08rbHJnd3BtblBjVEt0THc0cjVxLzhadmdTUUpVTGdwemhVVitW?= =?utf-8?B?V2dyUjUxYXVydUtVTkRuNGdYVmNjRW9KSzlzMDk1dERyMWh6TTdKektVSEY0?= =?utf-8?B?ZUF3akhNMkZqMFI4MW5iNzNNWkhKSTdJNEZCUnJhVWZGTGtEV0NPUTV0TklL?= =?utf-8?B?VEswZFRuZytlQ083MXlrNTlPNHlETGNaMzFpNktjOEo5RjhVa2sxQVEwMitz?= =?utf-8?B?RTZUSENBL2lLSXBaMHdUZjBmNmsxZzhuclBBUC9Xck1wbzFycVRqNzFqWUVm?= =?utf-8?B?aTl2eEhTT0IxcFZVSFNFVWhHVkgwZHRjK0ZhbVRYRjRERWt0bmJFK0Z6ZEpt?= =?utf-8?B?MnhjaG5RTHRyV2FFMVI1cEdwbXRzSW5YY08ycmovMlk4MXg2cmlqTjV3MUcw?= =?utf-8?B?RGZHZzlPVEFsZHdDTjdWWXc4bnFwcm13VHNvNnZ2L3Fra0V0THBmK0hoLzhT?= =?utf-8?B?UFVySHRmaGxJTFN5MVUwbkIvTmc2SitCZmF5YXJtU0c0QXdtTURhbU5kWFdG?= =?utf-8?B?aWRtbGZsSXVHYjVuQVJvQTE3NmRuUWw2YWdXRmdjZno1UUpTZjFkNEtOMWg0?= =?utf-8?B?Q2JORFdBdFlqUGNCbGtNUEQ3NCtIa25oWUJTODZKazlRVjRTLzVTQ1Z5ZmZW?= =?utf-8?B?OFBlWkZNd0JTb3JuU0tWeG9qSjd1R3MzSkw1clFHR1Z4LzdycUxseVgxL25Y?= =?utf-8?B?a2wrSXVucG43d1hJbUl3b0NqdUVDOXR2M2thditUYWx4WTkrOGJ0L3BiSDhz?= =?utf-8?B?Zm1nWGJybU4vYlVsNHIweWIxaFJ1dUZKSER6S3paWjU3UlBZKzZ1N3MxUEVB?= =?utf-8?B?dnlhaWRoaEFPTGdLaXNuYXZUamNEZjBPKzFLS2M0Wkc1SnRnRk1sRTlLdjIx?= =?utf-8?B?dTB5WGpBUDNKc2tMbm04emFqNkdzTnRyaG1jWk9ha2wxUjRsVldWb2lrRk1q?= =?utf-8?B?M040MWl4dXVlNng3YVRIUnZzNG0wYlFRZDNiSk9IMGxnU3Z1aTF4T3BwNDRE?= =?utf-8?B?S1B6a0dPYVNWdXBzZ3pWSVRKOEhTWitrUWM3YlhLa0VtODNzMGJVQXRDTVhv?= =?utf-8?B?ajBQV2hEK244T0dwckRHbGhkdzNSOFZoRG5vcEdJSjAzU2ZHUTBpdUFjQUph?= =?utf-8?B?b3duNTlYMWg4Vi9zK2RVcjJBUGNvQzlIbGtBbGw2dG1lTnZDeVJKRHZHUm1y?= =?utf-8?B?SUFNWFN1NUlSYndHMlBUdGpxclVtcldsUUlnaFRNYVZNdnhJdm5jME5GRWJE?= =?utf-8?B?Uk1BZU1GS3ZpWWFqUkxhWmdQbUhoT1FQWk1CbllPejdTL1JvbVhHRTJWckVj?= =?utf-8?B?bVNYcnRsY0tPc1NMMVMweFlRTHIrRTZSUFFhL1ZLcUplODhMeVNzWFBURUtM?= =?utf-8?B?d1FIWXozaHhmQUt2WE1PcFFvK0VLeDZkRXpkQT09?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e16c5ec-904d-4ad8-3ea3-08da0b7e07d4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 21:01:55.4606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jd+NInxlKGEIXg/8iTMsPLPSxYATbbN70x1JosjEfyv5j8we+IS+UzKcMx1yNmBzCy6cZwmF3DUZAkOfzsMjlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR17MB4232 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 21:01:59 -0000 On Mon, 2022-03-21 at 16:35 -0400, Simon Marchi wrote: > On 2022-03-16 11:09, Jan Vrany via Gdb-patches wrote: > > GDB notifies users about user selected thread changes somewhat > > inconsistently as mentioned on gdb-patches mailing list here: > >=20 > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__sourceware.org= _pipermail_gdb-2Dpatches_2022-2DFebruary_185989.html&d=3DDwICaQ&c=3DsPZ6DeH= LiehUHQWKIrsNwWp3t7snrE-az24ztT0w7Jc&r=3DWpFFGgYa98Yp-c29WHTCwU1wAGFBvszA6a= 4RzgpMSqc&m=3Dqn1ryn0GnzccCli0TKe7kc6WpMiz1opcXfyT-fLWkIk&s=3DXoLasKCD9agRg= S73PoGDnzPlKbo4_lL616HCUvldty0&e=3D=20 > >=20 > > Consider GDB debugging a multi-threaded inferior with both CLI and GDB/= MI > > interfaces connected to separate terminals. > >=20 > > Assuming inferior is stopped and thread 1 is selected, when a thread > > 2 is selected using '-thread-select 2' command on GDB/MI terminal: > >=20 > > -thread-select 2 > > ^done,new-thread-id=3D"2",frame=3D{level=3D"0",addr=3D"0x0000555555= 5551cd",func=3D"child_sub_function",args=3D[],file=3D"/home/jv/Projects/gdb= /users_jv_patches/gdb/testsuite/gdb.mi/user-selected-context-sync.c",fullna= me=3D"/home/uuu/gdb/gdb/testsuite/gdb.mi/user-selected-context-sync.c",line= =3D"30",arch=3D"i386:x86-64"} > > (gdb) > >=20 > > and on CLI terminal we get the notification (as expected): > >=20 > > [Switching to thread 2 (Thread 0x7ffff7daa640 (LWP 389659))] > > #0 child_sub_function () at /home/uuu/gdb/gdb/testsuite/gdb.mi/use= r-selected-context-sync.c:30 > > 30 volatile int dummy =3D 0; > >=20 > > However, now that thread 2 is selected, if thread 1 is selected > > using 'thread-select --thread 1 1' command on GDB/MI terminal > > terminal: > >=20 > > -thread-select --thread 1 1 > > ^done,new-thread-id=3D"1",frame=3D{level=3D"0",addr=3D"0x00005555555= 55294",func=3D"main",args=3D[],file=3D"/home/jv/Projects/gdb/users_jv_patch= es/gdb/testsuite/gdb.mi/user-selected-context-sync.c",fullname=3D"/home/jv/= Projects/gdb/users_jv_patches/gdb/testsuite/gdb.mi/user-selected-context-sy= nc.c",line=3D"66",arch=3D"i386:x86-64"} > > (gdb) > >=20 > > but no notification is printed on CLI terminal, despite the fact > > that user selected thread has changed. > >=20 > > The problem is that when `-thread-select --thread 1 1` is executed > > then thread is switched to thread 1 before mi_cmd_thread_select () is > > called, therefore the condition "inferior_ptid !=3D previous_ptid" > > there does not hold. > >=20 > > To address this problem, we have to move notification logic up to > > mi_cmd_execute () where --thread option is processed and notify > > user selected contents observers there if context changes. > >=20 > > However, this in itself breaks GDB/MI because it would cause context > > notification to be sent on MI channel. This is because by the time > > we notify, MI notification suppression is already restored (done in > > mi_command::invoke(). Therefore we had to lift notification suppression > > logic also up to mi_cmd_execute (). This change in made distinction > > between mi_command::invoke() and mi_command::do_invoke() unnecessary > > as all mi_command::invoke() did (after the change) was to call > > do_invoke(). So this patches removes do_invoke() and moves the command > > execution logic directly to invoke(). > >=20 > > With this change, all gdb.mi tests pass, tested on x86_64-linux. > >=20 > > Co-authored-by: Andrew Burgess > > Bug: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__sourceware.= org_bugzilla_show-5Fbug.cgi-3Fid-3D20631&d=3DDwICaQ&c=3DsPZ6DeHLiehUHQWKIrs= NwWp3t7snrE-az24ztT0w7Jc&r=3DWpFFGgYa98Yp-c29WHTCwU1wAGFBvszA6a4RzgpMSqc&m= =3Dqn1ryn0GnzccCli0TKe7kc6WpMiz1opcXfyT-fLWkIk&s=3D_9JOeNLk-p5CQtAtasdJbRyV= 5KK5tq1qLb_IxeKdmMw&e=3D=20 >=20 > Hi, >=20 > I see this on Ubuntu 20.04, am I the only one? Weird. I just compiled GDB commit f55649cc and see no such failures: > make check RUNTESTFLAGS=3D'TRANSCRIPT=3Dy gdb.mi/user-select*.exp' ... Running /home/jv/Projects/gdb/origin_master/gdb/testsuite/gdb.mi/user-selec= ted-context-sync.exp ... =3D=3D=3D gdb Summary =3D=3D=3D # of expected passes 419 I'll try on Ubuntu 20.04 tomorrow.=20 Jan >=20 > FAIL: gdb.mi/user-selected-context-sync.exp: mode=3Dall-stop: test_mi_thr= ead_select: thread 1.2: -thread-select again, event on CLI, ensure no outpu= t CLI > FAIL: gdb.mi/user-selected-context-sync.exp: mode=3Dall-stop: test_mi_thr= ead_select: thread 1.3: -thread-select again, event on CLI, ensure no outpu= t CLI > FAIL: gdb.mi/user-selected-context-sync.exp: mode=3Dnon-stop: test_mi_thr= ead_select: thread 1.2: -thread-select again, event on CLI, ensure no outpu= t CLI >=20 > Just the first one here: >=20 > -thread-select 2 > ^done,new-thread-id=3D"2",frame=3D{level=3D"0",addr=3D"0x00005555555551b8= ",func=3D"child_sub_function",args=3D[],file=3D"/home/smarchi/src/binutils-= gdb/gdb/testsuite/gdb.mi/user-selected-context- > sync.c",fullname=3D"/home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.mi/u= ser-selected-context-sync.c",line=3D"33",arch=3D"i386:x86-64"} > (gdb) > PASS: gdb.mi/user-selected-context-sync.exp: mode=3Dall-stop: test_mi_thr= ead_select: thread 1.2: -thread-select again > [Switching to thread 1.2 (Thread 0x7ffff7d99700 (LWP 1763981))] > #0 child_sub_function () at /home/smarchi/src/binutils-gdb/gdb/testsuite= /gdb.mi/user-selected-context-sync.c:33 > 33 dummy =3D !dummy; /* thread loop line */ > print 666 > $9 =3D 666 > (gdb) FAIL: gdb.mi/user-selected-context-sync.exp: mode=3Dall-stop: test_= mi_thread_select: thread 1.2: -thread-select again, event on CLI, ensure no= output CLI >=20 > Simon