From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [pushed] Invert test in gdb.ada/ptype_tagged_param.exp
Date: Fri, 27 Jan 2023 20:15:47 +0000 [thread overview]
Message-ID: <89869c3c-0a4f-67e3-dd98-13ea090b31c6@palves.net> (raw)
In-Reply-To: <20230127172427.4132635-1-tromey@adacore.com>
On 2023-01-27 5:24 p.m., Tom Tromey via Gdb-patches wrote:
> Simon pointed out that the kfail check in
> gdb.ada/ptype_tagged_param.exp is inverted. See:
>
> https://sourceware.org/pipermail/gdb-patches/2023-January/196296.html
>
> This patch fixes the problem.
> ---
> gdb/testsuite/gdb.ada/ptype_tagged_param.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp
> index eaf61ddde79..759b10f9b6a 100644
> --- a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp
> +++ b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp
> @@ -48,7 +48,7 @@ gdb_test_multiple "ptype s" "ptype s" {
> pass $gdb_test_name
> }
> -re -wrap $nodebug {
> - if {$has_runtime_debug_info} {
> + if {!$has_runtime_debug_info} {
> kfail "no debug info" $gdb_test_name
Why is this a kfail instead of an xfail? Is there really a GDB bug here?
> } else {
> fail $gdb_test_name
>
next prev parent reply other threads:[~2023-01-27 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 17:24 Tom Tromey
2023-01-27 20:15 ` Pedro Alves [this message]
2023-01-27 21:01 ` Tom Tromey
2023-01-27 21:11 ` Pedro Alves
2023-01-30 15:03 ` Tom Tromey
2023-01-30 15:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89869c3c-0a4f-67e3-dd98-13ea090b31c6@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).