From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id 321B43858D20 for ; Fri, 27 Jan 2023 20:15:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 321B43858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f43.google.com with SMTP id h16so5943257wrz.12 for ; Fri, 27 Jan 2023 12:15:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3Oh+JnWAvVDuT7RGAgBHu/L8tWQiaHMY6dBLlBEO2Y=; b=CcJzXKUS4BY4w5v64Ty48DDTcsC6uyZdeURB7Sk/LNN9rdpRFAQcncTiI1OLwBznW/ gUKHxbsvg3RCc+vVHYzuuDYBMRm68KyEqyDaMWSh6EV73nEf43j3x6YwH52no4fpYV3M gF8BfdCsiDdbWXCAcSxgUqxGLJRPii/AxBmTok2anmzeYuPU27/OCGutRfGAOIPGEt1V uJFbJZi13en1DhWsJT2vxy7hBNle5l8ck7MEePeWMp+nfbKqnwEh0GEuObTkgAJJ4/7Q UsfOr0w7Z0yHkj2LXjjvH7oISKFB4oWgRIv0VMxXDz0+JPHmCZMBAJuJna83WXjn72Bq cEDg== X-Gm-Message-State: AFqh2koNxHrFRjjACpiboTrV5kra7UgtnuLnahPu5W/jnVXXaDAJ3jML CbKehH+ohmZVMWibHHZ1zMKVQsmb/dUwzA== X-Google-Smtp-Source: AMrXdXs/7YigxC492yuO6tnghSFRVAu1u2LyAzap2td1HNHeoOVHg6GYhD/e0Agnx3tKeq06h6SM7A== X-Received: by 2002:a05:6000:a09:b0:2bd:e095:3f8f with SMTP id co9-20020a0560000a0900b002bde0953f8fmr38518655wrb.55.1674850549589; Fri, 27 Jan 2023 12:15:49 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id r28-20020adfa15c000000b002bfd137ecddsm2864896wrr.11.2023.01.27.12.15.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 12:15:49 -0800 (PST) Subject: Re: [pushed] Invert test in gdb.ada/ptype_tagged_param.exp To: Tom Tromey , gdb-patches@sourceware.org References: <20230127172427.4132635-1-tromey@adacore.com> From: Pedro Alves Message-ID: <89869c3c-0a4f-67e3-dd98-13ea090b31c6@palves.net> Date: Fri, 27 Jan 2023 20:15:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230127172427.4132635-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-27 5:24 p.m., Tom Tromey via Gdb-patches wrote: > Simon pointed out that the kfail check in > gdb.ada/ptype_tagged_param.exp is inverted. See: > > https://sourceware.org/pipermail/gdb-patches/2023-January/196296.html > > This patch fixes the problem. > --- > gdb/testsuite/gdb.ada/ptype_tagged_param.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > index eaf61ddde79..759b10f9b6a 100644 > --- a/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > +++ b/gdb/testsuite/gdb.ada/ptype_tagged_param.exp > @@ -48,7 +48,7 @@ gdb_test_multiple "ptype s" "ptype s" { > pass $gdb_test_name > } > -re -wrap $nodebug { > - if {$has_runtime_debug_info} { > + if {!$has_runtime_debug_info} { > kfail "no debug info" $gdb_test_name Why is this a kfail instead of an xfail? Is there really a GDB bug here? > } else { > fail $gdb_test_name >