Re: [PATCH] [gdb/cli] Add command: show logging active

[Tom de Vries <tdevries@suse.de>]

On 11/23/21 2:30 PM, Simon Marchi wrote:
> On 2021-11-23 06:49, Tom de Vries via Gdb-patches wrote:
>> [was: [pushed] [gdb/cli] Add command: show logging active ]
>>
>> Sorry, this has not been pushed yet, correcting $subject to request review.
>>
>> Thanks,
>> - Tom
>>
>> On 11/23/21 12:46 PM, Tom de Vries via Gdb-patches wrote:
>>> Currently, there's no gdb command that shows whether logging is enabled or
>>> disabled.
>>>
>>> There's the show logging command, but output is identical in both cases.
>>> With logging disabled, we have:
>>> ...
>>> (gdb) set logging off
>>> (gdb) show logging
>>> logging debugredirect:  The logging output mode is off.
>>> logging file:  The current logfile is "gdb.txt".
>>> logging overwrite: \
>>>   Whether logging overwrites or appends to the log file is off.
>>> logging redirect:  The logging output mode is off.
>>> ...
>>> and with logging enabled we have:
>>> ...
>>> (gdb) set logging on
>>> Copying output to gdb.txt.
>>> Copying debug output to gdb.txt.
>>> (gdb) show logging
>>> logging debugredirect:  The logging output mode is off.
>>> logging file:  The current logfile is "gdb.txt".
>>> logging overwrite: \
>>>   Whether logging overwrites or appends to the log file is off.
>>> logging redirect:  The logging output mode is off.
>>> ...
>>>
>>> Add a "show logging active" command, such that we have:
>>> ...
>>> (gdb) show logging
>>> logging active:  Logging is disabled.
>>> logging debugredirect:  The logging output mode is off.
>>> logging file:  The current logfile is "gdb.txt".
>>> logging overwrite: \
>>>   Whether logging overwrites or appends to the log file is off.
>>> logging redirect:  The logging output mode is off.
>>> ...
>>>
>>> Mention the new command in NEWS and docs.
>>>
>>> Tested on x86_64-linux.
> 
> This looks a whole lot like what we discussed for "set debuginfod"  and
> "set index-cache" recently.  See:
> 
> https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html
> 
> We then made the following changes.  Add the "set index-cache enabled
> on/off" setting, and make "set index-cache on/off" deprecated aliases of
> that:
> 
> https://gitlab.com/gnutools/binutils-gdb/-/commit/7bc5c369fae6dda3657467aee14e352a66b4270f
> 
> Change "set debuginfod on/off" to "set debuginfod enabled on/off",
> without aliases because it was never released:
> 
> https://gitlab.com/gnutools/binutils-gdb/-/commit/333f35b6315f6ed71db4fb76bfc1ebb7ec347d43
> 
> So, I would suggest doing the same as I did with index-cache, make "set
> logging on/off" deprecated aliases of a new "set logging enabled on/off"
> setting.

Done (
https://sourceware.org/pipermail/gdb-patches/2021-November/183749.html
), though I see now that I've copied the "help doc" ;) .

Proposed a fixup here (
https://sourceware.org/pipermail/gdb-patches/2021-November/183759.html ).

Thanks,
- Tom