From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 54FB5385840E for ; Wed, 24 Nov 2021 11:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54FB5385840E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FC3A1FD2F; Wed, 24 Nov 2021 11:06:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7473D13EFF; Wed, 24 Nov 2021 11:06:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cFhHG8IcnmFyeAAAMHmgww (envelope-from ); Wed, 24 Nov 2021 11:06:42 +0000 Subject: Re: [PATCH] [gdb/cli] Add command: show logging active To: Simon Marchi , gdb-patches@sourceware.org, Eli Zaretskii References: <20211123114603.6284-1-tdevries@suse.de> <9ab6df29-2990-704c-ea96-6af09d2e9a1e@suse.de> <77e5e956-8781-8cd3-27f8-83274412da1b@polymtl.ca> From: Tom de Vries Message-ID: <899e1aa8-a887-770b-1417-982f9b5ff272@suse.de> Date: Wed, 24 Nov 2021 12:06:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <77e5e956-8781-8cd3-27f8-83274412da1b@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 11:06:44 -0000 On 11/23/21 2:30 PM, Simon Marchi wrote: > On 2021-11-23 06:49, Tom de Vries via Gdb-patches wrote: >> [was: [pushed] [gdb/cli] Add command: show logging active ] >> >> Sorry, this has not been pushed yet, correcting $subject to request review. >> >> Thanks, >> - Tom >> >> On 11/23/21 12:46 PM, Tom de Vries via Gdb-patches wrote: >>> Currently, there's no gdb command that shows whether logging is enabled or >>> disabled. >>> >>> There's the show logging command, but output is identical in both cases. >>> With logging disabled, we have: >>> ... >>> (gdb) set logging off >>> (gdb) show logging >>> logging debugredirect: The logging output mode is off. >>> logging file: The current logfile is "gdb.txt". >>> logging overwrite: \ >>> Whether logging overwrites or appends to the log file is off. >>> logging redirect: The logging output mode is off. >>> ... >>> and with logging enabled we have: >>> ... >>> (gdb) set logging on >>> Copying output to gdb.txt. >>> Copying debug output to gdb.txt. >>> (gdb) show logging >>> logging debugredirect: The logging output mode is off. >>> logging file: The current logfile is "gdb.txt". >>> logging overwrite: \ >>> Whether logging overwrites or appends to the log file is off. >>> logging redirect: The logging output mode is off. >>> ... >>> >>> Add a "show logging active" command, such that we have: >>> ... >>> (gdb) show logging >>> logging active: Logging is disabled. >>> logging debugredirect: The logging output mode is off. >>> logging file: The current logfile is "gdb.txt". >>> logging overwrite: \ >>> Whether logging overwrites or appends to the log file is off. >>> logging redirect: The logging output mode is off. >>> ... >>> >>> Mention the new command in NEWS and docs. >>> >>> Tested on x86_64-linux. > > This looks a whole lot like what we discussed for "set debuginfod" and > "set index-cache" recently. See: > > https://sourceware.org/pipermail/gdb-patches/2021-October/182937.html > > We then made the following changes. Add the "set index-cache enabled > on/off" setting, and make "set index-cache on/off" deprecated aliases of > that: > > https://gitlab.com/gnutools/binutils-gdb/-/commit/7bc5c369fae6dda3657467aee14e352a66b4270f > > Change "set debuginfod on/off" to "set debuginfod enabled on/off", > without aliases because it was never released: > > https://gitlab.com/gnutools/binutils-gdb/-/commit/333f35b6315f6ed71db4fb76bfc1ebb7ec347d43 > > So, I would suggest doing the same as I did with index-cache, make "set > logging on/off" deprecated aliases of a new "set logging enabled on/off" > setting. Done ( https://sourceware.org/pipermail/gdb-patches/2021-November/183749.html ), though I see now that I've copied the "help doc" ;) . Proposed a fixup here ( https://sourceware.org/pipermail/gdb-patches/2021-November/183759.html ). Thanks, - Tom