From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 2EE633850632 for ; Fri, 16 Dec 2022 13:09:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2EE633850632 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso1733138wmo.1 for ; Fri, 16 Dec 2022 05:09:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d822uLmckhQX5mFBNGoUBO1od51hZZiUyVX5BjMHQVc=; b=ivXwf2X6dEaaOs82Egif0swXT+IaVZmDSQaOptScJptZHhHM9+CNzHMHq2raC6n/5x aP3l2KjrooJwpInsAR2D4v/ReqlANvZbwojTTp+ofTKnkV9N9BWBCq1D25f+ssEU0uwP zOBfDAWi93spildvg6NbD0bQZaM8qf1JxjbiX6UTTajv3W5ZZ6sIAnuOym7MejZX3oif yXsk4IHZqh2Ln3d8emUiq98KLv3/KTa9vNmZoIWltanpSA1+8oyw80Mxd0nvTsshsh/O uNjFy+jCCu+MinbZbVanVS8KCwiEYUq+NT15IkPLBClKpSJub0rk7LDcfT9EZvLRaYgd RHww== X-Gm-Message-State: ANoB5pkE0ijiu/1mb4oPJDWEvomruBTbJC1BKun9RVPf2SYAQwnuXmcw eRN2Ao/DQhQvW7vMd1S2KlaJe+SO7OdPbw== X-Google-Smtp-Source: AA0mqf7n9mafpYsu5+QsOne7sA/J+GX+gv51yxeW/EuAEYCAfcKhYRhtfqHoYqgApsHBDy6seZ/kqw== X-Received: by 2002:a05:600c:502c:b0:3cf:900c:de6b with SMTP id n44-20020a05600c502c00b003cf900cde6bmr25370825wmr.15.1671196146714; Fri, 16 Dec 2022 05:09:06 -0800 (PST) Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id r8-20020a05600c35c800b003a2f2bb72d5sm13730424wmq.45.2022.12.16.05.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 05:09:06 -0800 (PST) Subject: Re: [PATCH 0/2] Remove one use of struct buffer To: Simon Marchi , gdb-patches@sourceware.org References: <20221216060148.1261366-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <89bc07a5-59a4-272f-f30e-0fd5e3fe3ccd@palves.net> Date: Fri, 16 Dec 2022 13:09:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20221216060148.1261366-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-12-16 6:01 a.m., Simon Marchi via Gdb-patches wrote: > Tom mentioned the goal of getting rid of struct buffer, and that made me > remember I had these patches laying around. > Yeah, IIRC, struct buffer existed avoid obstack in gdbserver I think because back then gdbserver didn't link with libiberty. There used to be a obstack_xml_printf function too, which was eliminated too since. Glad to see it all go. > Simon Marchi (2): > gdbsupport: add string_xml_appendf > gdb: convert linux-osdata.c from buffer to std::string LGTM. ("There is not change" -> "There is no change" in patch 2's commit log.) > > gdb/nat/linux-osdata.c | 287 +++++++++++++++++++++------------------- > gdbsupport/xml-utils.cc | 105 +++++++++++++++ > gdbsupport/xml-utils.h | 10 ++ > 3 files changed, 263 insertions(+), 139 deletions(-) > > > base-commit: de75275fe54c5536c8238f0f3f88bb7ac2222942 >