Re: [PATCH] gdb/testsuite: Fix testing of "info copying"

[Keith Seitz <keiths@redhat.com>]

Hi,

On 1/10/24 18:59, Thiago Jung Bauermann wrote:
> gdb.base/default.exp has an incomplete test for the "info copying" command,
> as poetically pointed out by the FIXME removed by this patch.

Thank you for the patch... Oh, that FIXME! 🤣

> The test omits the pattern argument to gdb_test, which causes it to just
> check for a GDB prompt at the end of the command output.
> 
> The problem is that the command output is the whole GPLv3 license, which
> due to its size causes the test to fail sometimes, making the testcase to
> be out of sync with GDB's output and failing the tests that follow
> it. E.g.,
> 
>    FAIL: gdb.base/default.exp: info copying (timeout)
>    FAIL: gdb.base/default.exp: info display
>    FAIL: gdb.base/default.exp: info frame "f" abbreviation
>    PASS: gdb.base/default.exp: info frame
>    FAIL: gdb.base/default.exp: info files
>    FAIL: gdb.base/default.exp: info float
>    FAIL: gdb.base/default.exp: info functions
>    FAIL: gdb.base/default.exp: info locals
>    FAIL: gdb.base/default.exp: info program
>    FAIL: gdb.base/default.exp: info registers
>    FAIL: gdb.base/default.exp: info stack "s" abbreviation
> 
> Fix by by checking for a few excerpts at the beginning, middle and end of
> the license text.  This makes the test consume the command's output in
> smallish chunks.

While I'm not really in favor of copying large swaths of text from
compiled code into the test suite, this text changes very infrequently.
I think the last time it was updated was around 2007?

So I think this is easily outweighed by the need to strive for
more deterministic test results.

Reviewed-by: Keith Seitz <keiths@redhat.com>

Thank you!
Keith