From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND'
Date: Wed, 11 Jul 2018 10:58:00 -0000 [thread overview]
Message-ID: <89ff2c0a-2654-d4a6-ded9-65bf726a61bf@redhat.com> (raw)
In-Reply-To: <20180710213926.32240-1-philippe.waroquiers@skynet.be>
On 07/10/2018 10:39 PM, Philippe Waroquiers wrote:
> This is the fifth iteration of the patch series that:
> * implements a new command
> 'frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND'.
> * enhance 'thread apply COMMAND' by adding FLAG arguments.
> * adds some shortcuts commands.
> * documents the above in gdb.texinfo and NEWS.
> * adds a unit test for cli-utils.c.
> * adds test for 'frame apply'.
> * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments.
>
> The fifth version is RFA v4. It handles the third set of comments
> given by Pedro.
> The main changes compared to RFA v3 are:
> * frame level LEVEL... replaces frame id ID...
Very nice.
The changes to the testcases and the unit tests makes
them much clearer, IMHO, well done.
This version looks great to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-07-11 10:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 21:39 Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 6/8] Add a test for 'frame apply' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 4/8] Documents the new commands 'frame apply', faas, taas, tfaas Philippe Waroquiers
2018-07-11 3:06 ` Eli Zaretskii
2018-07-11 5:57 ` Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 1/8] Add helper functions parse_flags and parse_flags_qcs Philippe Waroquiers
2018-07-30 20:16 ` Joel Brobecker
2018-07-30 21:10 ` Tom Tromey
2018-07-31 13:52 ` Joel Brobecker
2018-07-31 15:41 ` Tom Tromey
2018-07-31 21:13 ` Philippe Waroquiers
2018-08-01 4:04 ` Tom Tromey
2018-08-01 4:34 ` Tom Tromey
2018-07-30 21:48 ` Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 5/8] Announce the user visible changes for frame/thread apply in NEWS Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 3/8] Add [FLAG]... arguments to 'thread apply' Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 7/8] Modify gdb.threads/pthreads.exp to test FLAG qcs arguments for thread apply. Also, add prefixes to make some non unique tests unique Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 8/8] Add a self-test for cli-utils.c Philippe Waroquiers
2018-07-10 21:39 ` [RFA_v4 2/8] Implement frame apply [all | COUNT | -COUNT | level LEVEL... ] [FLAG]... COMMAND Philippe Waroquiers
2018-07-14 1:49 ` Simon Marchi
2018-07-14 12:37 ` Tom Tromey
2018-07-11 10:58 ` Pedro Alves [this message]
2018-07-12 21:12 ` [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ff2c0a-2654-d4a6-ded9-65bf726a61bf@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).