From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH 1/2] gdb/testsuite: use test_gdb_complete_unique more in C++ tests
Date: Thu, 12 Jan 2023 19:08:10 +0000 [thread overview]
Message-ID: <8a024e8dabe4c53d0b3bd307d42e92572bf5f4c7.1673550414.git.aburgess@redhat.com> (raw)
In-Reply-To: <cover.1673550414.git.aburgess@redhat.com>
Spotted in gdb.cp/cpcompletion.exp that we could replace some uses of
gdb_test with test_gdb_complete_unique, this will extend the
completion testing to check tab-completion as well as completion using
the 'complete' command in some additional cases.
---
gdb/testsuite/gdb.cp/cpcompletion.exp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.cp/cpcompletion.exp b/gdb/testsuite/gdb.cp/cpcompletion.exp
index 931f376a23d..371e90cca7d 100644
--- a/gdb/testsuite/gdb.cp/cpcompletion.exp
+++ b/gdb/testsuite/gdb.cp/cpcompletion.exp
@@ -85,16 +85,16 @@ if {![runto "${srcfile}:$bp_location"]} {
# This also tests inheritance -- completion should only see a single
# "get_foo".
-gdb_test "complete p foo1.g" "p foo1\\.get_foo"
+test_gdb_complete_unique "p foo1.g" "p foo1.get_foo"
# Test inheritance without overriding.
-gdb_test "complete p foo1.base" "p foo1\\.base_function_only"
+test_gdb_complete_unique "p foo1.base" "p foo1.base_function_only"
# Test non-completion of constructor names.
-gdb_test "complete p foo1.Fo" "p foo1\\.Foofoo"
+test_gdb_complete_unique "p foo1.Fo" "p foo1.Foofoo"
# Test completion with an anonymous struct.
-gdb_test "complete p a.g" "p a\\.get"
+test_gdb_complete_unique "p a.g" "p a.get"
with_test_prefix "expression with namespace" {
# Before the scope operator, GDB shows all the symbols whose
--
2.25.4
next prev parent reply other threads:[~2023-01-12 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:08 [PATCH 0/2] Cleanup the gdb.cp/cpcompletion.exp test Andrew Burgess
2023-01-12 19:08 ` Andrew Burgess [this message]
2023-01-12 19:08 ` [PATCH 2/2] gdb/testsuite: rename test source file to match test script Andrew Burgess
2023-01-25 10:13 ` [PATCH 0/2] Cleanup the gdb.cp/cpcompletion.exp test Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a024e8dabe4c53d0b3bd307d42e92572bf5f4c7.1673550414.git.aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).