From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36705 invoked by alias); 18 May 2018 23:39:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36696 invoked by uid 89); 18 May 2018 23:39:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:907 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 23:39:48 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id A4.45.31227.1446FFA5; Sat, 19 May 2018 01:39:45 +0200 (CEST) Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSHC005.ericsson.se (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.382.0; Sat, 19 May 2018 01:39:01 +0200 Received: from ESESSMB502.ericsson.se (153.88.183.163) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sat, 19 May 2018 01:39:01 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sat, 19 May 2018 01:39:00 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [IPv6:2001:470:b2b5:2013:1c20:e8d0:dee6:d21d] (2001:470:b2b5:2013:1c20:e8d0:dee6:d21d) by BN7PR15MB2388.namprd15.prod.outlook.com (2603:10b6:406:8c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 23:38:57 +0000 Subject: Re: [RFC 1/5] Add helper functions check_for_flags and check_for_flags_vqcs To: Philippe Waroquiers , Simon Marchi , References: <20180505192804.12731-1-philippe.waroquiers@skynet.be> <20180505192804.12731-2-philippe.waroquiers@skynet.be> <0a630fc9-18bd-6d3b-5558-9a0389c64d4f@simark.ca> <1526679741.1604.9.camel@skynet.be> From: Simon Marchi Message-ID: <8a4748e7-7ce7-443f-e10c-e5a4cd66ea80@ericsson.com> Date: Sat, 19 May 2018 06:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526679741.1604.9.camel@skynet.be> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0028.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00::41) To BN7PR15MB2388.namprd15.prod.outlook.com (2603:10b6:406:8c::26) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BN7PR15MB2388; X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2388;3:UhO+a1Nd7crndUAWGSJh7cM1B3Q+s5tuRDKqZGecqq/YDP0eIyeDXyHdsP3XNG9RZZXtDjYX39r53Wafr3xrI+1n0f8AUz13vQ427jNH7fk/gGIYlXi7TPSY2Xkr2eLuTh7OQwvQdYgwpLLgX711Vwk7gA4n4N+KsGJf3JDU5IxUcFTqpHj+eSW75APvM0J1sFfVcSVdxuqblX9ni8v5qlei0+Y75bMd4qBsxmuxYm2YkN3mKDNccn+WSMFa3spg;25:JLDl8GtTo+YgMzLby1sr6kYg/AkkHad3zttcizaOw4dyBGruh1uYNiMd1IMrXTrFTmcosClt0EwsNbybI0eKti9W7A9R/n5jOSQCQI5COySVvZ8qdFIr/GUQmMjgDq59XwouT+Ey8RoUhDGO1gunWMUdBpvR8DEAsEpqEdmebfCWQ8tzE3jfC0WlTXooSb6yhbMS4cqWfTv6o7QnPNLQP9sBuCqzeLfQUkATSGJ3Z48W7FNmSR8w53DC2FcnQSSPu0D3OXRKU4XtJd/1MhCJwmv6xBx/7wo6MpUPWfK8WEq88VMvaUcJjFzBYffRj8mJjoXmR9V4MuGQ8h+DLHXVUw==;31:EmZL9zq1Yw5WMwi9IlhBFoyHxCmrq44jrwWeobEDM/3qhmpCpLN8HwHcBijpLtRdXyHNIkqVC41cMEa90bxE8c/3FRRaB+9qdRji6qCHRRRjpOG8svrjDfNanyb/Qo0ktQCDJeEJx0vtLrPlNoGBaUTgiSjapcNdabVV/4S8CxBocLErEzPKHF4WwFcMEed6S9oR1juwSI2ngZGFddGDWEwCeLDG2tLbS+RjZI8IsGI= X-MS-TrafficTypeDiagnostic: BN7PR15MB2388: X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2388;20:fP2yNtbSQUQwuIJ881+uMjNuWOKTd7+mJYejQIrLf6vCs4KhKtuqK/mYrJeng46524ojHrMzC4cFzGNOnsYTvrVIwqeWhLtiwN6OGmnQ9SyWhHzKqwGYG/x4UutQYjr2lJw6Hmr18j9yDy81SsdyDmYAAFrErsiVFRp2HfQCCn+q+fWtGXBB8r+RbLUWqNZcIwrXvqwZQVSZqWl9RJkS1PenpAK+y6E73ZZR8bc3OQInN5X0QKLrTjIbuF9y+P6whAifyErXhdlAA3LYpA1rUMgTmyADC8kmXoijJDe2O5i+qewc44k9TE7hDRWnRV9g3t0PYDpeXYg5Hrhgq2Z882fQRtnunUBD6hN/SLUPDi3KNnjg3eWRVG+724XOcyBDSgnZe2/IPFymsVZL5U9n7SSLmM4HifQsolpx7K4Uf9s0i7ItBjXqIdQ35tYcLkF00bGjtMA8RYf6HBHigRKNEV0YxZlWcDijOh9pgL3S1UAfPEkdhaxDlfEzyWfAv3og;4:MX+ffYuRsonM3p7pd4MRYiLi3ULPP2UU9fCJheUQCYP7LYaX6dG/lWjQ2TNPJOEo0jvEsBaCfep2fagsjfznbJqhMrVz/k33dRBuhoYnVfIecb4NOCMihsGPZic36XSH+U51nB09fNS0L0JRLdCnzsivaRuKu1VipwoSROOHVy63Tzs5BPurZHRbTOqxiQsLvdfuS0u2L+g0BQHPBiv1c0GgbsEqmeP6HGloPrDJ3TubsNHH0hRpMp57f15a6cJheautY+EZr+c/N3B5QCWN2w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:BN7PR15MB2388;BCL:0;PCL:0;RULEID:;SRVR:BN7PR15MB2388; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(396003)(376002)(346002)(39380400002)(189003)(377424004)(199004)(2616005)(5660300001)(229853002)(8936002)(65956001)(486006)(105586002)(47776003)(106356001)(476003)(31686004)(46003)(446003)(52146003)(11346002)(2486003)(2906002)(65806001)(8676002)(81156014)(23676004)(81166006)(44832011)(36756003)(76176011)(52396003)(52116002)(478600001)(6486002)(6116002)(1706002)(65826007)(230700001)(25786009)(53936002)(97736004)(186003)(316002)(58126008)(16526019)(305945005)(7736002)(64126003)(6666003)(6246003)(110136005)(50466002)(93886005)(68736007)(31696002)(53546011)(386003)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR15MB2388;H:[IPv6:2001:470:b2b5:2013:1c20:e8d0:dee6:d21d];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjE1TUIyMzg4OzIzOjJXT3RLMUNxYWJSbXd6SFhKdldIMnVuLzA5?= =?utf-8?B?WUZrVklSNU5oNXdUQ2F6YWJuOGVDdkRZQStIUzlOcFBSZ3pXUHRIdXA2Q3lJ?= =?utf-8?B?M2FmUVAwdEhRbDJWQjQyeXAvVkpNTzZ1RldJbUJtcWdTaEZHSDk2WHEzakJl?= =?utf-8?B?SThCZDJ4c3VPc2dBQU8va2RPWnVUcnNUQnhsRWJLYXUvMUMrZHNQY3p4ZE5V?= =?utf-8?B?ckttRzZrMDkrWVJmSGFVa21ZOFdvOXpCLzlZMTdEL1ZoTEhxdXR5V1VMQWF6?= =?utf-8?B?SW9HWEFaRlpueVFjUVBZRi9ONG5EQjF5K1A4RnNmcm1SZmhmL0JaOWxqNEJx?= =?utf-8?B?S0tjRm1raEVweDE4aW5PK2FITUVCbUdGUEFNQlZMWXNmZW1SMTdocm9hdzZ6?= =?utf-8?B?WS9ES1diODFTR1h2TllwMXE3dTJ3aTh2ZU1VREk3b3lzSFdjbDNMeVdpMm1V?= =?utf-8?B?UWEwa05DNGkydFhuSVFLRVpPTmdXSVdIYjRuZnRMQ2QxcFpHYmdMSHJaSmxt?= =?utf-8?B?MDhPTUFFdWxya20rcEVzQTZIUlBHWGhrRnU1MFJXUXZEWjEzZUttSnJ1a0lH?= =?utf-8?B?Yk5xMmNSUmk3cmV3T1JrR29wNDJMRUNYU21ERUdwWVcrdUU0VVhZMVBZbXdk?= =?utf-8?B?SnZxY3pTdjB2QmRBK3UyS1lzdnRER1k0V3RBTi9WWnpYUjdJWmpWS21KcHQ3?= =?utf-8?B?UWNvVHc4Si9QRlNCLzFVNkhpOWtRTFVXdGtxZzdYUk8yakhlK3hnM3Vqa28v?= =?utf-8?B?UExsT2VWZ0xFQXM0R3RwZWFVMTFpME5taHhCbTRKVE14L0tVUDFUZEV0dE9D?= =?utf-8?B?cTVDTlJQMi9JTlhvSnBsTTd2blp2TWJjUTJKRWtXUmxvOTJMdldGcVEvMHZp?= =?utf-8?B?UEtza0thcGk4MVRTd24wZkJrNkZudnFtSGhnQ0pZNy9hRU95QkpJcHhOT2gv?= =?utf-8?B?NXdBWnFhcTNtalppM0hzWktKVVQ4QlRVRUxsWThJVWR1MHhkU0NLaDNkbXgr?= =?utf-8?B?NWJUd1c1YWhidWZPcTUrTlN6OEdCTnBKbkRJRUUrR1FQbUZ6KzhPUi9CYVR5?= =?utf-8?B?d3pXdUVFU0NqMUxIazZpZ0VKZEFWaXBDRDljSUpTVDRTSTJyVDZvM2Y1cG5X?= =?utf-8?B?WUlYVEQ3Tzl6ZHQ2VlJnRmFnNzF4QmxpUGpUWEQ0aVg2WWp1bVhIZnBIbDRU?= =?utf-8?B?VFFtd3pKakJpNjUxNUJLK1liLzF5NGVvM0V6REI3a3lUd295bkQvcnFJN09E?= =?utf-8?B?SGF4VGpyVWFXWmJzRCthU1Y5cUNmdlU2c0g3K1F2RHBpNysvMXM0NjNmNlRC?= =?utf-8?B?Zi8vOEluU0phOTBCcUhsMHFCWDc2UGJqTEdxQnorNzMwRmRnSGpVbDNmUFBR?= =?utf-8?B?My80M0Q1Nng0T0ozcHVaNGRBdWtDR3QzSVgxVlVzZHViTE9UNVBTM3N6bGYr?= =?utf-8?B?ZmhGWDJLYjNtYnBXRDhJN2NCRWFWbEV5SW1MOHp4MG1Vb29KVDhXNHNlVHU5?= =?utf-8?B?OEJYeWwvbVIyUEF4WThrcDZUZm5hWmNZWU9SeWkrR3dBUUQ0UkRYUkk2YUdm?= =?utf-8?B?QTJoRUtJUS9YLzI0OFF2bUJMVFZVUzU5ckNXZi96NXNuNGw0VHFib09ZT2xq?= =?utf-8?B?TmEwdjNIdlBacmNqSlNDUUd3RUJ2QzhGWCtQYTRaeERtZWduNTlHOGw3QVRD?= =?utf-8?B?YjFMSzlLRWhBYlBDb1BLRHk1QlUwV21sUkRtbUEwZEp4UGEvZ1RuM2FOeEIw?= =?utf-8?B?Wk9Ddmx0WE85RC9WaHZzdnBoMkR1Z1FiYjRIVWFaUjFnTzUxK0htbllTVXZ5?= =?utf-8?B?dkVVdkRoMVFWQVg3WTAwdzAxRHZSU05TTmxqeWlKWUJFdzYxeVFzVUI0aDY3?= =?utf-8?Q?DhC0JDd2/AplvnW7lB8Wn4rAwb4HnL+I?= X-Microsoft-Antispam-Message-Info: I7fXBtpQkKr6G4Vx3+Jfr+2EKrJAsoFCihALuVyqbfgINoAC7kakS7JcVtHtJaDwJnGlKxHvg+uRg/4ZTlITbi+gkzW5tGJAiTfwziKZyAW+w0V+/X4yilu7Vy3AKDcbaD09IHaWAuGXK6LrV9Ziqa486HCF5T0DZ7rM8VsGD1cxpFYqJzLrTZPrK9dihENm X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2388;6:WeXoZG2kKZlA493slplmnpVOpwQZdMcWm4jv4Jqe5Mcty45qcoIE5LET0eNRisaOZVmh9oSYqVn3zoJnDOPg6ozFDesoLj1NlHgI/fFMneQcoqOzkdXrip53+A+WGINFurTWMKPZDb7BRJmtRraH89xaucj5FtI/dry9PBCAO5M510mJstEa6f0WrzquJi3buOpOAOG6P1CmaRrHFp5RBe7ue2shNy416AeM0i5iWN8v5axNSZPZnIv8iDXL6rhy2ye87+BMKLMk4MyWOLYrEzbKqgRE1QZU/HLwozMLqlunKLK7yAAbZ3z/CPimNYmTh2NAxLdvlQ7KAT/Kyc0jka441QgyAk48LyLB63ncgCqlSf6bU3kUt9611Araq//dHD639dWGJB741N98Rxcxz+uo8zNVpIgfa3Fefx7myHiAURGVa/t26augEQI0aNZ4Eshvj3dPIabpfit3y3ptTw==;5:ow5GvakGIzm3Hu+L3ciE21BfJMsz/NwJbaiS0GlkCi3frO6mbyOEm0AqCPbL0gv9eKhZU0UPTFga0TMAYRN2rzqiQzuMeg491xKNZOQl1K3pdDHh0ZAECu3HPWm4tL/Ims8fNrb6zztnC+DTfx+UwgsNnj8xNp9yO5AkcXVOrlU=;24:HmqwGSqBfkzM35G2xDVTlc4KLbni3HU+K9tc2AIEjChmageBrIjd7xdyHOOy7RvSFOufOeY6i4BL8+Q6LiPqWrIUVRttdr8HYE1LX9ty32Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2388;7:dENubLaGDMu4osJy/ok2UQpTi3UKqI/dfGuvdFIQUtBweKV3gp+8dUZcZOBx7Uh8qS2azGCO51BKWfk2QmIJmXRE+J1zz1EtIEzGi/Nq3Cm4R/oWWrH2mNmWLu8vjJU0Ri60uqN2DZGNIy7AQ+NbFJTtcuJDKj2H+UsC590enD4bc9rRrWD9blHPgjua2WmVqsnI/ADs+QQrTPe4IwWTOMhbNIn1LsB0iLpXfNVKdShZ7VYzvPiN5EH3Fz/e76x7 X-MS-Office365-Filtering-Correlation-Id: b9040f22-0e3b-44ad-c587-08d5bd188695 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 23:38:57.4026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b9040f22-0e3b-44ad-c587-08d5bd188695 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2388 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00432.txt.bz2 On 2018-05-18 05:42 PM, Philippe Waroquiers wrote: > On Thu, 2018-05-17 at 21:22 -0400, Simon Marchi wrote: >>> + /* First set the flags_counts to 0. */ >>> + { >>> + const char *f = flags; >>> + while (*f) >>> + { >>> + flags_counts[f - flags] = 0; >>> + f++; >>> + } >>> + } >> >> What about something like >> >> memset (flags_count, 0, sizeof (flags_count[0]) * strlen (flags)); > > The code initialising the flags_counts is somewhat similar in structure > to the code that increments the flags_counts. > > So, it looks more clear to me to have the zero-ing code and > the incrementing code looking like each other. > > But if for gdb, using memset is the typical pattern to zero > an array of int, fine for me. > > What do you think ? I don't really mind, I just thought the memset was short and clear, but both work. Simon