From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 72B2A3858D32 for ; Sat, 11 Feb 2023 13:47:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72B2A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CED641E112; Sat, 11 Feb 2023 08:47:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676123227; bh=azySX2qEHDYIGRjeO8nlIH7k8VVPHEC+Gwxi7mwodNs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n8Pr23M8PWnF+gXONthphMuNsKfvOWcKvtBuer6py51VLiL+L/n13LV4R304Y70GT SCnHBYeyV0789k2WHFryWNsh7TI96L0gO9DrSrPqdLEKEsxweMgooDPyuCQJTYT5Yt GF+ijqf674bISqSVwpQVuPLdP9x9l3v+lUUcV2Ow= Message-ID: <8a76a754-cff7-603b-91db-866d76ce457e@simark.ca> Date: Sat, 11 Feb 2023 08:47:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 00/48] Use methods for struct value Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org Cc: Simon Marchi References: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/11/23 08:40, Simon Marchi via Gdb-patches wrote: > > > On 2/10/23 16:52, Tom Tromey wrote: >> This is v2 of the struct value series. The original cover letter is >> below. >> >> This series changes many value-related functions to be methods. It >> also moves the definition of struct value to value.h, so that callers >> will benefit by inlining the smaller methods. The members of value >> are all made private at the end of the series. >> >> It's difficult to decide exactly which value functions ought to be >> converted, because there are so many. In the end I chose a relatively >> minimal approach -- only those that require direct access to the inner >> workings of value. >> >> It's possible, even easy, to convert more functions. If there are >> some in particular that seem worthwhile, let me know. >> >> I tacked on one small cleanup at the end of this series, but as it was >> already fairly long, I didn't try to do all the possible cleanups. >> For example, many things could use bool, some of the setter functions >> could be removed in favor of specialized constructors, etc. >> >> Regression tested on x86-64 Fedora 36. >> >> Tom > > I regtested on my end, it looks good. > > Simon Note that you'll have some non-trivial rebasing to do, because of a patch that went in meanwhile. Simon