From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20964 invoked by alias); 18 May 2018 21:09:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19571 invoked by uid 89); 18 May 2018 21:09:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=spoke X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 21:09:41 +0000 Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 5A.87.27207.3114FFA5; Fri, 18 May 2018 23:09:39 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC023.ericsson.se (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 23:09:38 +0200 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 23:09:38 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 23:09:38 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 21:09:35 +0000 Subject: Re: [PATCH 05/10] remote: remote_arch_state pointers -> remote_arch_state objects From: Simon Marchi To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-6-palves@redhat.com> <2f2b904b-7ceb-ef99-8017-1ea42c241f17@ericsson.com> Message-ID: <8a8783b3-0d5b-c7e7-886c-13c52aaa1ddd@ericsson.com> Date: Fri, 18 May 2018 21:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2f2b904b-7ceb-ef99-8017-1ea42c241f17@ericsson.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0401CA0025.namprd04.prod.outlook.com (2603:10b6:803:2a::11) To BYAPR15MB2391.namprd15.prod.outlook.com (2603:10b6:a02:8c::31) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2391; X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;3:2hhths7HFnEYHS941aIpJ2B98fRaclebY7+rn+MrEuMBXuFSIjeHs96Xr8HcwgkZkDmUpG1IG8Y+jBYwkFTYGVhKURnVnoyutmeA+LVA7TLpqkZ8xWz5JsBCNb9UnO/jE2tJA0AgZVxho+qdDYAyR80ENxYq16X9+6LoynKJo0I2vFO/ErO02+qxGGf+oJQll/f9UXSDmjA1Gs929B/v7rKMNNooAZ/F7S4vKskMY7YQUzvU+m5eQTgLb2SiVLlq;25:ChcliOeR7GGmhuXAQNGzuyt8Rra4DYtQXUBQCXSA75MFT1lqWVO4zWKPab2uWri7rF8vWdqmBJGcu00b78LaL8v4Y5N0gM/RLE9ndDd7YVx8ZfsX0FZMkm5lyWjeUS7D54U3DePC8n5Ra2ztOdLvzz+xPjm8LthNTHvfCpreOx/bbzzkpNTjiftyCh+msipCi8BG5LO6PIdoJZDTHRaWfOVQXtoljeVGZ5fDX5THG3xJDLC3ELH/aa5nOIfvpZeVafFyqsUh8NmULAgfD+lmSDNGGGieclM6Qi5ubVYG5cOMOaOqyrGCDuh3biQZJFaVzvBDo2WGVNwVnGNXrGCvQg==;31:9QErMh0d+vuKi9WuuCykpK2i8aB4mzhgq1Y7XeYj9mIjui7oIECtzlpkC7X7yaQSiIMi/Y09sNd2TNchGAVktgRBQ7K6aguGtTTWHwW+vhtm4WGgOJo9wtkMKgtCvObwjIZVgN2SNdW9iymaN7Z6wBQ0RBcRcxYi9M5qpY62Yl/RwR7dJ4ehcrszf5dIQm/gAdYkYtxV7ppjI5ELpv55ugStroWWLUltMbDP3V+03QI= X-MS-TrafficTypeDiagnostic: BYAPR15MB2391: X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;20:Sas9XfPAAGw2zaAc4FfTu6H40ndmyiaIR/o/LUXo7sKEEVrPOK1WDa7rgfdVfVgA5SMkjagr8Goewf4QQW2us6mTVwNUiF8BfedMsae6lv79NVl62lb96KfKpFKJSI3zwn+iwybNLcLoRC6jtcMNy8HEqUKWyB+Evpdbq+FA2px4ddG5gsd7uHu6pg9Q1qXQHd/o+rzwRVbqy0o92TUjqxVLn2tDgZZ4teAeh8MHMFBHCEFRBdcAMGXfNnMlDfgdi/TslQQ83U/G1bdKqJZwYzUsfa9uW5YJVJ9/0bOmENWb9N970Xy/X1eyUdEG9N5o6NFIHhejMef4lqcyPoknJEVPLIUMmWB0junPA33HCMYzQw1gy9LTbUcchNJX68l6NcrNbE4C6MbYKe20vxd0VPcenYlErCh2L7rvYn4isQ9RAcKwTNocNbt6vnHqjIh16t1ePN8iRH71SQaHoGSzZSPVD7qUJXn8EDzktDRn2rQmWVmeStNr3+q4WOdFxbnS;4:G6dtZox6NRuVvThZ/3DMlFcN6tcRc3xNXZ4heAeTK+LFa7P2dwSzoYDI18NG09WzUizPCwkMvVCDHjDXmJ/KMNBNpxM6tmrAEknAR42LMZBwGCGtKFeNF39qODc2NNJtWokAneDdaY61OJnqDRJMtoZH58Ue5ak6kHNtFY0hgN/b5LSgQrW7osax+BJA+sWz1jGiMPGTYSVkLX1StStUC2TV1IOdqTf2kr57mGtHiQjCTkjJgKf+lf+ePpFxUrwFVCDdv73SqxxwNycbaOfPSQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:BYAPR15MB2391;BCL:0;PCL:0;RULEID:;SRVR:BYAPR15MB2391; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(346002)(366004)(376002)(39380400002)(39860400002)(377424004)(189003)(199004)(2616005)(106356001)(446003)(105586002)(11346002)(956004)(53936002)(16576012)(316002)(7736002)(305945005)(25786009)(31686004)(6246003)(36756003)(186003)(16526019)(8676002)(58126008)(26005)(49976009)(6666003)(229853002)(6486002)(97736004)(81166006)(81156014)(8936002)(52116002)(76176011)(65826007)(2486003)(486006)(476003)(50466002)(52146003)(23676004)(31696002)(5660300001)(478600001)(68736007)(3846002)(65956001)(64126003)(53546011)(66066001)(65806001)(86362001)(386003)(2870700001)(6116002)(2906002)(47776003)(44832011)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR15MB2391;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjE1TUIyMzkxOzIzOmZKQWdwakc4eXhSUUtUYnd1UWM0aGl4enp4?= =?utf-8?B?aE55MW9hZjJRYUtDWHFPVUFLMWFHemltQUZiRlBmRDBnMnlXU2JTcEh3ZURB?= =?utf-8?B?aHd4OW9WQkp2REY1ODRxdGI2cDA4ZFBEMmJiWW9OM2p1V1JiQytRUUpSZlJl?= =?utf-8?B?QjFXYXF4alptOXhFWXptcFgzME9iZVNscEp4RUdVMTR6WXAreUxhK3JIMlVh?= =?utf-8?B?bzQxL3N5UFk1dHBWcERZOVRoTnpJcVc0RUh6U29uRHg4OEoyRno5MnRlNVdQ?= =?utf-8?B?SlN0U3p0QVpXUkM5ZzgvdXJDYWxiYmNmSjJyVklFTVZxSENXVlhnb25jNUNw?= =?utf-8?B?KzlqakdUbGRONmZrL0NDdFBTRkhSdWY1SE9DWE5GZGxQRVd2ZWNUZm84WWlU?= =?utf-8?B?N3lZQzc5N3hZSVlmUlEyWDg2WTRVeExDLzBJL25sV2J5UXFwZ0pzZVBYdEZC?= =?utf-8?B?QzRGQk9FSW1lTUVqQU13L0hobXBadUl1azdXN055cTFOSHFMVnRVS25obEh2?= =?utf-8?B?UVo4Qm4zTUdYSHk1aDJDM21DT2pDNmszZFJkeC9BM0svMys3YSt2cDBSM0F2?= =?utf-8?B?cjVJdW82QUZDRVZPM2VsUTdUeXpJbDNjYjhTR1duODhpRTB5aHRyRUhPenV6?= =?utf-8?B?aTlHVjNONEplQU5ValRzZmdUaldCZGo4V1gzcHJ1ZEpRRFJocWJSTDRwNk11?= =?utf-8?B?RjlyNnF2YWpJcmJSVVhHeHdBRFFGMXZsYk1qUS9pbW83czVyNlhNSy9iemho?= =?utf-8?B?S3Q3TVp6dUljeGRDWkJZSTR4bXlydDlocW44ZGNDVGVlQnh5a3JleTU2WmIv?= =?utf-8?B?WTM5b0JlRzJCMVVTOUpOMHFTend1bWpCODlHZUtRVkJZekI3ZkZDS2V1djFp?= =?utf-8?B?RVozWlh2WXJ3MExtYnBPYmpEeTVqbmlqUWNZQmNLak43OHpUWDcwSkJtS1kw?= =?utf-8?B?N0dUQnBhUVlYcTRVQ2NqR2Jkd1hoVSs1M1Zjc29ndEdrVXRXTXg2a3dNZER2?= =?utf-8?B?R3NVQW9Wak1ldVh2N2FaRjFSazZRdHYwbWFEWWFqS2RuRmRxNDN4bHNveUM2?= =?utf-8?B?UkRxclo3eFlwRzNLVzh4cHVKU1U3SGsrSlNmTzFFQWU0R0FGMWdNTXM3anIw?= =?utf-8?B?QmtGYmVydGtZaGxoWHBDeXlhME5TSDVxaytGSU5oYjNsaHhwNmsvRExXUkQ5?= =?utf-8?B?SzN4bFFnVjhyRDlxcjVsNW9PUnZObm1OWktpVVFXbEZTWVhhVE1NUDJzUDRj?= =?utf-8?B?SlhMZHFuWHdBOXhPWG9Fc1E0WmhDMTllQUVockVLcVJQTW5Lc0tnZnZ4N1BW?= =?utf-8?B?dzE3YVFlalF4b0laLzJoZnlySFVRUnhSMWN2bFNpNWk5MUZYcU5uNFc5a1J6?= =?utf-8?B?S09nVU5KQ0djL1ZncG9XeXFRN2M0QXJVVmY0SmtXVk9aVmNqWWEvdngzeFpI?= =?utf-8?B?bUJWTGxueDFPSFc2bWIyMVVyK0h1NkZvRnA1UUxncS9XSXVncUxWWlpBTG5x?= =?utf-8?B?WWE1MC9xK1g1Skx0ZTlsSEFGWlViUnRxQWM0M05sdHI0NHJzMFUxMHQzZC9D?= =?utf-8?B?Z1V3SmJSQVQ0ZWkybGkxaWJRL01HUXNmZnVVNnJlVUdCeVNCeExiL0tvcjJB?= =?utf-8?B?aVFTWURDWU1vaUxUZktoYjJaQ2tVeENLUnZ2R3JCc20ydjlHZEw3K2ZkSmtT?= =?utf-8?B?TnNsZlV3L3ZPam01NWVPYXVwR3lVcGJCdy9KalBtRThWajB2eVFUM2Irem1V?= =?utf-8?B?QUhJWG9TM3VxM2haU3RIL3BYUTIwMjFEUG9TakxjUmJNandTay9MZmI1YzJD?= =?utf-8?B?a2JKUFcxd1dYT2MwYUtOZWpmeEl0RmNkZXA1R0orTWpEcjVSdzdHUmJPNmdp?= =?utf-8?B?L1dwOGJ6YUFqTFlOVEYvcFY5OUpkTmdDVTJwSUlYNDFzaHB1ajlPUzQwaGc0?= =?utf-8?Q?wDFVR7eSzEa6hIdBlmS2oDllLYiyog=3D?= X-Microsoft-Antispam-Message-Info: yxQ9QRPWsJIPrQbTz4/UGwIdqVwhN4UGzPz6lGYdsUbC2BpjG4lfuNn0sz/bHG4XLn4MmNlK4hZOfO0JlSyCWvlGpj9/n/FPRipb7mc+KZXLXDTjypzaJ00P5b1/OCyNoMFU2S8AtBQ15dIg/5YnZhbvjYZE2Sq2H7xs0c6cagJa3tVBrPETWHGptJQIRsEZ X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;6:985VQ6CCiPFum+6hdMKcjQrXcFzyVvoDTBnaZ6hCiM3DAk0HehGzb5pWTBUtk/tf74WDSKoNiCrzsfY8kZVTns+M4It9YK+qP47gmG2eClJOJt2oxfpxS8aduDIUl6HWm7VjsBVWMAv27vpjrboTEKTzONzf8gDHHAmNKUppwRRqvhGV3JMkDDCF7aJPW+//cWXfJFWhtc6mlF82fsqBX8k12c89SJrEydFNsquOnvXmTYxS9TmPToOurJDNbUFaPIQoFBrXffeCStsvXq+AHv+/0dD+5GLNY/A9X5sTyPZxPpY6G715K+Y25PqcfjvtXU9KZtq8/AJ1PpvEdHldPcyzkb8Y5cJaYFPEkP1odwOs2BEWZqWOyCJwbdLsAQvTGMWi+VsuOvlv8oAN0gKT+K5HfOTe4zmD/vY4hg0y0lZh76toYYeU0HMjzT5xY3dSsMcqpWtACGoOlzvaZrqqyw==;5:3Lst2YPddDfIxicVLmPG2Xkb4110TNvgeLk10tOvU/9iBe4N+Zoz340LWzZ0DQeKilX6NbT7EEGkQkbeq5S3mhGxQjCKwS1YpkQ2eE28eiRg2a829NY3o1fiR2mpsHFDeNUJWLSROFXO0Bi52stn5qNWxkNXr/59MEHtMcT2Klc=;24:SaYgU5QkWDcEJK6ahwQMSXxiVodvPTcqshycfGX0Ffo491/ZATM/JqVT4EI+NVoyKP9oxJszERaju8aBG35kDzyKlhYmxR79Fl9Zc4ws9O0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2391;7:1HeDU1Srqzg+1SFH9VT3pIcG4w99zwedxW9xnCLsZobRw9ug7YrsUUuPjAR4imbnr35LxVJy0UNmer+DAkq0r6GvHTga08doXZ+qrDLoaE2YzVkGlhMRtjr5si4z8U1Nr6YYB3/7fSXAlLL+vHGmwwoWjy9+ITjneRiLF+3ObCPoTDtuO7J7Ign/snstBv0qezZHnLWnIZTXGOBYpnROSDy0oAA9MnOVlDeYU0nDipnvQpJjRE2lA7EfXr7B5vUn X-MS-Office365-Filtering-Correlation-Id: 23bcfbe2-fab0-4dda-4980-08d5bd03a8b7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 21:09:35.1866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23bcfbe2-fab0-4dda-4980-08d5bd03a8b7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2391 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00425.txt.bz2 On 2018-05-18 05:05 PM, Simon Marchi wrote: > On 2018-05-16 10:18 AM, Pedro Alves wrote: >> The previous patch made the map store pointers to remote_arch_state >> instead of objects directly, simply because struct remote_arch_state >> is still incomplete where struct remote_state is declared. This patch >> thus moves the remote_arch_state declaration higher up in the file, >> and makes the map store remote_arch_state objects directly instead of >> pointers to objects. > > LGTM. > > Simon > Oops, spoke a bit too soon. It fails to build with g++ 5.4.0 (Ubuntu 16.04). It doesn't like the "this->m_arch_states.emplace (gdbarch, gdbarch)". With g++ 7.1.0 it builds fine. /home/emaisin/src/binutils-gdb/gdb/remote.c:962:61: required from here /usr/include/c++/5/ext/new_allocator.h:120:4: error: no matching function for call to ‘std::pair::pair(gdbarch*&, gdbarch*&)’ { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); } ^ Simon