Re: [PATCH] gdb: remove core_bfd macro

[Simon Marchi <simon.marchi@efficios.com>]

On 2/5/24 20:03, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> The core_bfd macro hides a use of current_program_space.  Remove it, so
> Simon> that we have the opportunity to get the program space from the context,
> Simon> if possible.  I guess that the macro was introduced at some point to
> Simon> replace a global variable of the same name without changing all the
> Simon> uses.
> 
> Thanks.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, will push.

> These kinds of macros are bad; though at the same time I've added them
> on occasion to make some series simpler.  I may have even added this
> one, I didn't look.

I understand they help go quicker, but I don't mind doing the legwork
to get rid of them, I think it's worth it in the long run.

Simon