From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id BD5B33858CDB for ; Sat, 9 Dec 2023 08:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD5B33858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BD5B33858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702110595; cv=none; b=EMyic4zstnfy5GE0EULP+j/Mdb0lvrpFDW462hrd60kXzKgTbNLMlD5fSyECtDa5GL7JN9RjZLymp6zCAe461844qNM47HD5e0m5Ieh9H2Z3oQxtdb/2kjJyXC2Ep5ssNILsvSG/oQQrqSgoBB/Osp18UxbB0plMZCdjPN6zUXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702110595; c=relaxed/simple; bh=hqTyzY2raK1lAc+Sy5bAIeI++m8XtrfryBEA6tx3F5U=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=mHWAcPyUPiIfDAy3J2b2ezgZY0Z4WMMTc1dNz18UVaeHInRoAdXaXu/0EDRKSPWWTSUJrBi0/0j6EPzDT05aqcdn7U4Bz6c1AOiMzQ8pFH6Dt/pP9bn91waDotWVRwLN6JdD8jBcm7zGtzkpPYeVtOkm7py7sFvopZxPz3Vou4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A1AC1F7C9; Sat, 9 Dec 2023 08:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702110592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+QLob/+Eqgk2TNYhf+B/PKfXyJeqcdyFkrm0ylowH8=; b=fkZIkK9sRPpsASjj8zRcJGxktgSvHuLtsK58wSHWYu3N2+7X3RKZB2d393u2f1oIb/iWVt hOXcgUgcR1V/TRNiJECg42iO7mhv8BjKmBaEF/uU0dxE/Fnr3RiFkR4wIMNE7bbIeHpc+K BYCWNGpLgM0JlpPm2dTidJ7AF7RSFcM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702110592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+QLob/+Eqgk2TNYhf+B/PKfXyJeqcdyFkrm0ylowH8=; b=ZMAh+U8VG0N777T5q9jvGqaEExKNPnxVKqmvlB+vYgbo9rZDWit4IMLVkv2iCSQ+xCoA26 Neo1OSDeAReeKKBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702110592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+QLob/+Eqgk2TNYhf+B/PKfXyJeqcdyFkrm0ylowH8=; b=fkZIkK9sRPpsASjj8zRcJGxktgSvHuLtsK58wSHWYu3N2+7X3RKZB2d393u2f1oIb/iWVt hOXcgUgcR1V/TRNiJECg42iO7mhv8BjKmBaEF/uU0dxE/Fnr3RiFkR4wIMNE7bbIeHpc+K BYCWNGpLgM0JlpPm2dTidJ7AF7RSFcM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702110592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+QLob/+Eqgk2TNYhf+B/PKfXyJeqcdyFkrm0ylowH8=; b=ZMAh+U8VG0N777T5q9jvGqaEExKNPnxVKqmvlB+vYgbo9rZDWit4IMLVkv2iCSQ+xCoA26 Neo1OSDeAReeKKBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F24F3136D6; Sat, 9 Dec 2023 08:29:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4PxKOX8ldGXNeQAAD6G6ig (envelope-from ); Sat, 09 Dec 2023 08:29:51 +0000 Message-ID: <8a9ceb55-3d0b-47a3-8702-77272164e312@suse.de> Date: Sat, 9 Dec 2023 09:30:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231126075250.31557-1-tdevries@suse.de> <87y1e4hfvv.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87y1e4hfvv.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: ************* X-Spam-Score: 13.12 X-Spamd-Result: default: False [-9.94 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(0.00)[suse.de,none]; MX_GOOD(-0.01)[]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.94)[86.53%]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; WHITELIST_DMARC(-7.00)[suse.de:D:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Rspamd-Server: rspamd1 X-Spam-Level: X-Rspamd-Queue-Id: 1A1AC1F7C9 X-Spam-Score: -9.94 Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fkZIkK9s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZMAh+U8V; spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/23 16:29, Tom Tromey wrote: > This triggered a memory -- there's already weird state in this area, see > tui-hooks.c:tui_refreshing_registers. I have never understood why that > is needed. > > I wonder if this can be untangled. I don't know why it's needed either, and I didn't manage to trigger usage of it either. I've submitted a patch ( https://sourceware.org/pipermail/gdb-patches/2023-December/204933.html ) that changes behaviour from recursion prevention to asserting on recursion detection. Thanks, - Tom